-
Notifications
You must be signed in to change notification settings - Fork 439
feat(apm): add referrer hostname as span tag #12778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 232 ± 4 ms. The average import time from base is: 233 ± 4 ms. The import time difference between this PR and base is: -0.5 ± 0.2 ms. Import time breakdownThe following import paths have grown:
|
6c5ff75
to
e5468e5
Compare
BenchmarksBenchmark execution time: 2025-04-02 09:34:48 Comparing candidate commit 8ab9a24 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 498 metrics, 2 unstable metrics. |
feb42a7
to
503a329
Compare
503a329
to
e80421e
Compare
dee3b21
to
875e4c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some non blocking suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM!
8e6d2a9
to
8ab9a24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
Parses referrer hostname from http header when presents and adds it to span tags as `http.referrer_hostname`. This will be used to identify frontend clients without leaking the PII which can be contained in the entire referrer. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Parses referrer hostname from http header when presents and adds it to span tags as
http.referrer_hostname
. This will be used to identify frontend clients without leaking the PII which can be contained in the entire referrer.Checklist
Reviewer Checklist