Skip to content

chore: update protobuf latest version to 6.30.1 [recreated] #12995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Mar 31, 2025

Recreating #12754 because we needed to revert PRs that were accidentally merged prematurely due to required status checks getting deleted.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

.riot/requirements/1721018.txt                                          @DataDog/apm-python
.riot/requirements/1bf9721.txt                                          @DataDog/apm-python
.riot/requirements/26aada0.txt                                          @DataDog/apm-python
.riot/requirements/3b28562.txt                                          @DataDog/apm-python
.riot/requirements/4fe37f9.txt                                          @DataDog/apm-python
.riot/requirements/e222783.txt                                          @DataDog/apm-python

Copy link
Contributor

github-actions bot commented Mar 31, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 228 ± 3 ms.

The average import time from base is: 229 ± 2 ms.

The import time difference between this PR and base is: -1.5 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.875 ms (0.82%)
ddtrace.bootstrap.sitecustomize 1.243 ms (0.55%)
ddtrace.bootstrap.preload 1.243 ms (0.55%)
ddtrace.internal.products 1.243 ms (0.55%)
ddtrace.internal.remoteconfig.client 0.626 ms (0.27%)
ddtrace 0.631 ms (0.28%)

@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 31, 2025
@pr-commenter
Copy link

pr-commenter bot commented Mar 31, 2025

Benchmarks

Benchmark execution time: 2025-03-31 22:11:33

Comparing candidate commit 43789d1 in PR branch upgrade-latest-protobuf-version with baseline commit fb71cc7 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 498 metrics, 2 unstable metrics.

@erikayasuda erikayasuda marked this pull request as ready for review March 31, 2025 21:26
@erikayasuda erikayasuda requested a review from a team as a code owner March 31, 2025 21:26
@erikayasuda erikayasuda merged commit 961a8dc into main Mar 31, 2025
679 checks passed
@erikayasuda erikayasuda deleted the upgrade-latest-protobuf-version branch March 31, 2025 22:44
chojomok pushed a commit that referenced this pull request Apr 7, 2025
Recreating #12754 because we
needed to revert PRs that were accidentally merged prematurely due to
required status checks getting deleted.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: quinna-h <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants