fix(opentelemetry): fix Span.kind property to return SpanKind instead of str#13159
Closed
przlada wants to merge 10 commits intoDataDog:mainfrom
Closed
fix(opentelemetry): fix Span.kind property to return SpanKind instead of str#13159przlada wants to merge 10 commits intoDataDog:mainfrom
Span.kind property to return SpanKind instead of str#13159przlada wants to merge 10 commits intoDataDog:mainfrom
Conversation
christophe-papazian
approved these changes
Apr 11, 2025
mabdinur
approved these changes
Apr 15, 2025
ede0c76 to
d25236d
Compare
Span.kind property to return SpanKind instead of strSpan.kind property to return SpanKind instead of str
Author
|
Is there anything more I can or should do before this PR can be approved for running test workflows in CI? Everything is passing in my local environment, but it would be great to ensure I haven't overlooked anything |
PR Security UpdateAll commits in this PR up to and including 4f0d30d have been reviewed and marked safe by SDLC security. For any questions, please reach out to #ci-for-external-contributors-collab on Slack. |
Contributor
|
This pull request has been automatically closed after a period of inactivity. |
auto-merge was automatically disabled
June 29, 2025 00:09
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that the
Span.kindproperty from the OpenTelemetry integration is returning a string value instead of aSpanKindenum. Because of this, the logic for setting the operation name cannot work properlyI propose to merge these changes as they:
Span.kindproperty to return theSpanKindenum as it should, instead of a string valueSpan._datadog_operation_nameproperty will start to work properly (as it is comparing toSpanKindenum values). I also fixed the logic for when thenetwork.protocol.nameattribute is setChecklist
Reviewer Checklist