-
Notifications
You must be signed in to change notification settings - Fork 439
fix(futures): ensure child spans are correctly parented in Threadpools #13168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 231 ± 2 ms. The average import time from base is: 233 ± 3 ms. The import time difference between this PR and base is: -1.9 ± 0.1 ms. Import time breakdownThe following import paths have grown:
|
BenchmarksBenchmark execution time: 2025-05-02 17:18:26 Comparing candidate commit cd1a331 in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 512 metrics, 6 unstable metrics. scenario:iastdjangostartup-iast
scenario:otelspan-start
|
a837e6e
to
abb7ab1
Compare
This reverts commit abb7ab1.
9d96826
to
0fed321
Compare
fmt fix tornado test rn precheck
8c074e1
to
afd509b
Compare
This reverts commit afd509b.
b622981
to
82f137a
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.21 2.21
# Navigate to the new working tree
cd .worktrees/backport-2.21
# Create a new branch
git switch --create backport-13168-to-2.21
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 40fe58d21ae0abde036e9fc36bd0420f4efe7d6e
# Push it to GitHub
git push --set-upstream origin backport-13168-to-2.21
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.21 Then, create a pull request where the |
#13168) Introduces a private API for activating a trace `Context` in a contextmanager. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Introduces a private API for activating a trace
Context
in a contextmanager.Checklist
Reviewer Checklist