fix(symdb): switch _shallow to shallow in install [backport 3.8]#13528
Merged
fix(symdb): switch _shallow to shallow in install [backport 3.8]#13528
_shallow to shallow in install [backport 3.8]#13528Conversation
This fixes a bug introduced by #12957 where the shallow mode for SymDB was introduced. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 58bd69c)
ojung
approved these changes
May 28, 2025
Contributor
Author
|
|
Contributor
Author
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 230 ± 2 ms. The average import time from base is: 232 ± 2 ms. The import time difference between this PR and base is: -2.0 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-05-29 18:44:21 Comparing candidate commit 0140c6e in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 478 metrics, 7 unstable metrics. scenario:iast_aspects-replace_aspect
scenario:iast_aspects-upper_aspect
scenario:iastdjangostartup-iast
|
emmettbutler
approved these changes
May 29, 2025
tylfin
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 58bd69c from #13522 to 3.8.
This fixes a bug introduced by #12957 where the shallow mode for SymDB was introduced.
Checklist
Reviewer Checklist