chore(profiling): validate trigger-ability of profiling_native tests in CI - take 2#16566
chore(profiling): validate trigger-ability of profiling_native tests in CI - take 2#16566vlad-scherbich wants to merge 11 commits intomainfrom
Conversation
…ml stay in sync with the actual file tree
|
@brettlangdon I fat-fingered merging of the first PR. In this new PR, I've addressed your #16564 (comment) |
This comment has been minimized.
This comment has been minimized.
Performance SLOsComparing candidate vlad/trigger-native-tests-by-file-extension-pattern-validation (83f24d1) with baseline main (a5b7406) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 102.369µs (SLO: <130.000µs 📉 -21.3%) vs baseline: -0.4% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ add_inplace_aspectTime: ✅ 100.944µs (SLO: <130.000µs 📉 -22.4%) vs baseline: -2.3% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.1% ✅ add_inplace_noaspectTime: ✅ 28.635µs (SLO: <40.000µs 📉 -28.4%) vs baseline: +1.9% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ add_noaspectTime: ✅ 48.794µs (SLO: <70.000µs 📉 -30.3%) vs baseline: +0.2% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ bytearray_aspectTime: ✅ 251.681µs (SLO: <400.000µs 📉 -37.1%) vs baseline: +1.8% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ bytearray_extend_aspectTime: ✅ 631.654µs (SLO: <800.000µs 📉 -21.0%) vs baseline: -2.5% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.3% ✅ bytearray_extend_noaspectTime: ✅ 263.629µs (SLO: <400.000µs 📉 -34.1%) vs baseline: -2.0% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ bytearray_noaspectTime: ✅ 137.029µs (SLO: <300.000µs 📉 -54.3%) vs baseline: -3.1% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.2% ✅ bytes_aspectTime: ✅ 218.709µs (SLO: <300.000µs 📉 -27.1%) vs baseline: -0.6% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ bytes_noaspectTime: ✅ 133.618µs (SLO: <200.000µs 📉 -33.2%) vs baseline: -0.7% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ bytesio_aspectTime: ✅ 3.776ms (SLO: <5.000ms 📉 -24.5%) vs baseline: -0.7% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ bytesio_noaspectTime: ✅ 316.488µs (SLO: <420.000µs 📉 -24.6%) vs baseline: -0.5% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ capitalize_aspectTime: ✅ 88.854µs (SLO: <300.000µs 📉 -70.4%) vs baseline: +0.2% Memory: ✅ 42.861MB (SLO: <46.000MB -6.8%) vs baseline: +4.5% ✅ capitalize_noaspectTime: ✅ 253.142µs (SLO: <300.000µs 📉 -15.6%) vs baseline: -0.6% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.5% ✅ casefold_aspectTime: ✅ 88.936µs (SLO: <500.000µs 📉 -82.2%) vs baseline: -0.1% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ casefold_noaspectTime: ✅ 306.898µs (SLO: <500.000µs 📉 -38.6%) vs baseline: -1.3% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ decode_aspectTime: ✅ 86.853µs (SLO: <100.000µs 📉 -13.1%) vs baseline: +0.6% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ decode_noaspectTime: ✅ 151.567µs (SLO: <210.000µs 📉 -27.8%) vs baseline: -1.0% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ encode_aspectTime: ✅ 84.688µs (SLO: <200.000µs 📉 -57.7%) vs baseline: +0.5% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ encode_noaspectTime: ✅ 140.945µs (SLO: <200.000µs 📉 -29.5%) vs baseline: -0.4% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ format_aspectTime: ✅ 14.646ms (SLO: <19.200ms 📉 -23.7%) vs baseline: -0.2% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.3% ✅ format_map_aspectTime: ✅ 16.371ms (SLO: <21.500ms 📉 -23.9%) vs baseline: ~same Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +4.6% ✅ format_map_noaspectTime: ✅ 371.720µs (SLO: <500.000µs 📉 -25.7%) vs baseline: -1.4% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ format_noaspectTime: ✅ 303.633µs (SLO: <500.000µs 📉 -39.3%) vs baseline: -1.1% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ index_aspectTime: ✅ 124.123µs (SLO: <300.000µs 📉 -58.6%) vs baseline: -0.5% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ index_noaspectTime: ✅ 40.250µs (SLO: <300.000µs 📉 -86.6%) vs baseline: +0.6% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ join_aspectTime: ✅ 210.799µs (SLO: <300.000µs 📉 -29.7%) vs baseline: -1.4% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.0% ✅ join_noaspectTime: ✅ 140.124µs (SLO: <300.000µs 📉 -53.3%) vs baseline: -1.5% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ ljust_aspectTime: ✅ 578.115µs (SLO: <700.000µs 📉 -17.4%) vs baseline: 📈 +14.8% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.3% ✅ ljust_noaspectTime: ✅ 256.368µs (SLO: <300.000µs 📉 -14.5%) vs baseline: -2.2% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ lower_aspectTime: ✅ 293.707µs (SLO: <500.000µs 📉 -41.3%) vs baseline: -2.5% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.3% ✅ lower_noaspectTime: ✅ 238.354µs (SLO: <300.000µs 📉 -20.5%) vs baseline: +0.8% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ lstrip_aspectTime: ✅ 0.268ms (SLO: <3.000ms 📉 -91.1%) vs baseline: -2.9% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ lstrip_noaspectTime: ✅ 0.177ms (SLO: <3.000ms 📉 -94.1%) vs baseline: -1.3% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ modulo_aspectTime: ✅ 14.338ms (SLO: <18.750ms 📉 -23.5%) vs baseline: -0.3% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.2% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.791ms (SLO: <19.350ms 📉 -23.6%) vs baseline: +0.1% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +4.6% ✅ modulo_aspect_for_bytesTime: ✅ 14.368ms (SLO: <18.900ms 📉 -24.0%) vs baseline: -0.1% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +4.6% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.606ms (SLO: <19.150ms 📉 -23.7%) vs baseline: ~same Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.5% ✅ modulo_noaspectTime: ✅ 0.362ms (SLO: <3.000ms 📉 -87.9%) vs baseline: -0.8% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ replace_aspectTime: ✅ 18.553ms (SLO: <24.000ms 📉 -22.7%) vs baseline: +0.5% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.4% ✅ replace_noaspectTime: ✅ 279.556µs (SLO: <300.000µs -6.8%) vs baseline: -2.3% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ repr_aspectTime: ✅ 311.111µs (SLO: <420.000µs 📉 -25.9%) vs baseline: -3.8% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ repr_noaspectTime: ✅ 46.449µs (SLO: <90.000µs 📉 -48.4%) vs baseline: -0.2% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ rstrip_aspectTime: ✅ 382.992µs (SLO: <500.000µs 📉 -23.4%) vs baseline: +0.1% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ rstrip_noaspectTime: ✅ 185.621µs (SLO: <300.000µs 📉 -38.1%) vs baseline: +0.4% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ slice_aspectTime: ✅ 185.082µs (SLO: <300.000µs 📉 -38.3%) vs baseline: +2.0% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.2% ✅ slice_noaspectTime: ✅ 53.960µs (SLO: <90.000µs 📉 -40.0%) vs baseline: -0.4% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.3% ✅ stringio_aspectTime: ✅ 3.813ms (SLO: <5.000ms 📉 -23.7%) vs baseline: -0.8% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ stringio_noaspectTime: ✅ 378.540µs (SLO: <500.000µs 📉 -24.3%) vs baseline: +7.2% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.3% ✅ strip_aspectTime: ✅ 267.411µs (SLO: <350.000µs 📉 -23.6%) vs baseline: -3.7% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ strip_noaspectTime: ✅ 176.260µs (SLO: <240.000µs 📉 -26.6%) vs baseline: -1.7% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ swapcase_aspectTime: ✅ 333.208µs (SLO: <500.000µs 📉 -33.4%) vs baseline: -1.9% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ swapcase_noaspectTime: ✅ 272.949µs (SLO: <400.000µs 📉 -31.8%) vs baseline: -0.7% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ title_aspectTime: ✅ 319.779µs (SLO: <500.000µs 📉 -36.0%) vs baseline: -2.1% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ title_noaspectTime: ✅ 260.359µs (SLO: <400.000µs 📉 -34.9%) vs baseline: -0.6% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ translate_aspectTime: ✅ 489.882µs (SLO: <700.000µs 📉 -30.0%) vs baseline: -2.0% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ translate_noaspectTime: ✅ 424.985µs (SLO: <500.000µs 📉 -15.0%) vs baseline: -1.6% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.3% ✅ upper_aspectTime: ✅ 294.477µs (SLO: <500.000µs 📉 -41.1%) vs baseline: -1.4% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.2% ✅ upper_noaspectTime: ✅ 237.130µs (SLO: <400.000µs 📉 -40.7%) vs baseline: +0.4% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.3% 📈 iastaspectsospath - 23/23✅ ospathbasename_aspectTime: ✅ 510.715µs (SLO: <700.000µs 📉 -27.0%) vs baseline: 📈 +19.4% Memory: ✅ 42.585MB (SLO: <46.000MB -7.4%) vs baseline: +4.2% ✅ ospathbasename_noaspectTime: ✅ 429.441µs (SLO: <700.000µs 📉 -38.7%) vs baseline: -0.5% Memory: ✅ 42.664MB (SLO: <46.000MB -7.3%) vs baseline: +4.6% ✅ ospathjoin_aspectTime: ✅ 627.958µs (SLO: <700.000µs 📉 -10.3%) vs baseline: +1.0% Memory: ✅ 42.703MB (SLO: <46.000MB -7.2%) vs baseline: +5.0% ✅ ospathjoin_noaspectTime: ✅ 634.397µs (SLO: <700.000µs -9.4%) vs baseline: +0.3% Memory: ✅ 42.625MB (SLO: <46.000MB -7.3%) vs baseline: +4.4% ✅ ospathnormcase_aspectTime: ✅ 350.664µs (SLO: <700.000µs 📉 -49.9%) vs baseline: -0.4% Memory: ✅ 42.546MB (SLO: <46.000MB -7.5%) vs baseline: +4.2% ✅ ospathnormcase_noaspectTime: ✅ 357.950µs (SLO: <700.000µs 📉 -48.9%) vs baseline: +0.3% ✅ ospathsplit_aspectTime: ✅ 491.084µs (SLO: <700.000µs 📉 -29.8%) vs baseline: +0.9% Memory: ✅ 42.585MB (SLO: <46.000MB -7.4%) vs baseline: +4.4% ✅ ospathsplit_noaspectTime: ✅ 498.266µs (SLO: <700.000µs 📉 -28.8%) vs baseline: -0.4% Memory: ✅ 42.644MB (SLO: <46.000MB -7.3%) vs baseline: +4.2% ✅ ospathsplitdrive_aspectTime: ✅ 377.005µs (SLO: <700.000µs 📉 -46.1%) vs baseline: +1.1% Memory: ✅ 42.467MB (SLO: <46.000MB -7.7%) vs baseline: +3.5% ✅ ospathsplitdrive_noaspectTime: ✅ 73.367µs (SLO: <700.000µs 📉 -89.5%) vs baseline: +0.2% Memory: ✅ 42.664MB (SLO: <46.000MB -7.3%) vs baseline: +4.5% ✅ ospathsplitext_aspectTime: ✅ 458.234µs (SLO: <700.000µs 📉 -34.5%) vs baseline: ~same Memory: ✅ 42.664MB (SLO: <46.000MB -7.3%) vs baseline: +4.1% ✅ ospathsplitext_noaspectTime: ✅ 463.743µs (SLO: <700.000µs 📉 -33.8%) vs baseline: -0.3% Memory: ✅ 42.585MB (SLO: <46.000MB -7.4%) vs baseline: +4.1%
|
brettlangdon
left a comment
There was a problem hiding this comment.
I think moving to suitespec would be better, but no reason to avoid this for now if it is working and providing the value you need
| @@ -0,0 +1,255 @@ | |||
| #!/usr/bin/env scripts/uv-run-script | |||
There was a problem hiding this comment.
awesome, yeah, this lgtm
you could remove the .py extension if you wanted to avoid any confusion over "should I use python <script>?"
but also, feedback welcome on this pattern for scripts (self-bootstrapping uv meaning almost 0 dependencies needed to onboard/run scripts).
https://datadoghq.atlassian.net/browse/PROF-13795
Description
Implement the following "Future Work" item from the base PR: #16501
This is a new lint that checks for two things:
breakage would only surface on scheduled/main pipelines).
Testing