chore(profiling): fix macos build after libdd upgrade#16592
chore(profiling): fix macos build after libdd upgrade#16592taegyunkim wants to merge 1 commit intomainfrom
Conversation
Codeowners resolved as |
Performance SLOsComparing candidate taegyunkim/fix-macos-build-profiling (4805a88) with baseline main (6dced39) 📈 Performance Regressions (2 suites)📈 iastaspects - 117/117✅ add_aspectTime: ✅ 103.109µs (SLO: <130.000µs 📉 -20.7%) vs baseline: +0.7% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ add_inplace_aspectTime: ✅ 101.153µs (SLO: <130.000µs 📉 -22.2%) vs baseline: -1.7% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.5% ✅ add_inplace_noaspectTime: ✅ 28.381µs (SLO: <40.000µs 📉 -29.0%) vs baseline: +0.4% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ add_noaspectTime: ✅ 48.875µs (SLO: <70.000µs 📉 -30.2%) vs baseline: -0.6% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ bytearray_aspectTime: ✅ 248.690µs (SLO: <400.000µs 📉 -37.8%) vs baseline: +0.4% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ bytearray_extend_aspectTime: ✅ 629.411µs (SLO: <800.000µs 📉 -21.3%) vs baseline: -4.2% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ bytearray_extend_noaspectTime: ✅ 264.018µs (SLO: <400.000µs 📉 -34.0%) vs baseline: -4.3% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.4% ✅ bytearray_noaspectTime: ✅ 136.028µs (SLO: <300.000µs 📉 -54.7%) vs baseline: -3.1% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ bytes_aspectTime: ✅ 219.295µs (SLO: <300.000µs 📉 -26.9%) vs baseline: +0.5% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ bytes_noaspectTime: ✅ 131.774µs (SLO: <200.000µs 📉 -34.1%) vs baseline: -3.0% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ bytesio_aspectTime: ✅ 3.780ms (SLO: <5.000ms 📉 -24.4%) vs baseline: -0.2% Memory: ✅ 42.861MB (SLO: <46.000MB -6.8%) vs baseline: +4.3% ✅ bytesio_noaspectTime: ✅ 314.178µs (SLO: <420.000µs 📉 -25.2%) vs baseline: -2.2% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ capitalize_aspectTime: ✅ 89.108µs (SLO: <300.000µs 📉 -70.3%) vs baseline: +0.2% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ capitalize_noaspectTime: ✅ 252.567µs (SLO: <300.000µs 📉 -15.8%) vs baseline: +0.8% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ casefold_aspectTime: ✅ 89.822µs (SLO: <500.000µs 📉 -82.0%) vs baseline: +1.1% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.6% ✅ casefold_noaspectTime: ✅ 306.154µs (SLO: <500.000µs 📉 -38.8%) vs baseline: -1.4% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.3% ✅ decode_aspectTime: ✅ 86.950µs (SLO: <100.000µs 📉 -13.1%) vs baseline: +0.4% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ decode_noaspectTime: ✅ 151.771µs (SLO: <210.000µs 📉 -27.7%) vs baseline: -2.0% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ encode_aspectTime: ✅ 83.896µs (SLO: <200.000µs 📉 -58.1%) vs baseline: -1.0% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ encode_noaspectTime: ✅ 140.190µs (SLO: <200.000µs 📉 -29.9%) vs baseline: -1.6% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ format_aspectTime: ✅ 14.548ms (SLO: <19.200ms 📉 -24.2%) vs baseline: -0.9% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 16.384ms (SLO: <21.500ms 📉 -23.8%) vs baseline: -0.3% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.3% ✅ format_map_noaspectTime: ✅ 368.502µs (SLO: <500.000µs 📉 -26.3%) vs baseline: -2.2% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 300.578µs (SLO: <500.000µs 📉 -39.9%) vs baseline: -3.0% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.3% ✅ index_aspectTime: ✅ 124.944µs (SLO: <300.000µs 📉 -58.4%) vs baseline: +3.4% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ index_noaspectTime: ✅ 40.315µs (SLO: <300.000µs 📉 -86.6%) vs baseline: -0.2% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ join_aspectTime: ✅ 210.876µs (SLO: <300.000µs 📉 -29.7%) vs baseline: -1.5% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ join_noaspectTime: ✅ 141.377µs (SLO: <300.000µs 📉 -52.9%) vs baseline: -0.3% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ ljust_aspectTime: ✅ 578.111µs (SLO: <700.000µs 📉 -17.4%) vs baseline: 📈 +14.5% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ ljust_noaspectTime: ✅ 259.090µs (SLO: <300.000µs 📉 -13.6%) vs baseline: +0.9% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ lower_aspectTime: ✅ 296.104µs (SLO: <500.000µs 📉 -40.8%) vs baseline: -1.9% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ lower_noaspectTime: ✅ 233.986µs (SLO: <300.000µs 📉 -22.0%) vs baseline: -0.2% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ lstrip_aspectTime: ✅ 0.272ms (SLO: <3.000ms 📉 -90.9%) vs baseline: -2.0% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.2% ✅ lstrip_noaspectTime: ✅ 0.178ms (SLO: <3.000ms 📉 -94.1%) vs baseline: -0.1% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ modulo_aspectTime: ✅ 14.334ms (SLO: <18.750ms 📉 -23.6%) vs baseline: +0.2% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.5% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.847ms (SLO: <19.350ms 📉 -23.3%) vs baseline: +0.6% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +4.6% ✅ modulo_aspect_for_bytesTime: ✅ 14.339ms (SLO: <18.900ms 📉 -24.1%) vs baseline: -0.5% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.3% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.646ms (SLO: <19.150ms 📉 -23.5%) vs baseline: +0.5% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +4.6% ✅ modulo_noaspectTime: ✅ 0.362ms (SLO: <3.000ms 📉 -87.9%) vs baseline: -0.8% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.3% ✅ replace_aspectTime: ✅ 18.394ms (SLO: <24.000ms 📉 -23.4%) vs baseline: ~same Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +4.6% ✅ replace_noaspectTime: ✅ 280.345µs (SLO: <300.000µs -6.6%) vs baseline: -0.9% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ repr_aspectTime: ✅ 308.016µs (SLO: <420.000µs 📉 -26.7%) vs baseline: -3.9% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ repr_noaspectTime: ✅ 46.613µs (SLO: <90.000µs 📉 -48.2%) vs baseline: -0.1% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.4% ✅ rstrip_aspectTime: ✅ 382.802µs (SLO: <500.000µs 📉 -23.4%) vs baseline: -0.4% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.4% ✅ rstrip_noaspectTime: ✅ 185.354µs (SLO: <300.000µs 📉 -38.2%) vs baseline: +0.1% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ slice_aspectTime: ✅ 185.572µs (SLO: <300.000µs 📉 -38.1%) vs baseline: +2.5% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ slice_noaspectTime: ✅ 54.294µs (SLO: <90.000µs 📉 -39.7%) vs baseline: +1.2% Memory: ✅ 42.861MB (SLO: <46.000MB -6.8%) vs baseline: +4.4% ✅ stringio_aspectTime: ✅ 3.839ms (SLO: <5.000ms 📉 -23.2%) vs baseline: -0.9% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ stringio_noaspectTime: ✅ 382.613µs (SLO: <500.000µs 📉 -23.5%) vs baseline: +6.8% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ strip_aspectTime: ✅ 268.063µs (SLO: <350.000µs 📉 -23.4%) vs baseline: -2.9% ✅ strip_noaspectTime: ✅ 178.231µs (SLO: <240.000µs 📉 -25.7%) vs baseline: -0.3% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ swapcase_aspectTime: ✅ 334.934µs (SLO: <500.000µs 📉 -33.0%) vs baseline: -0.1% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ swapcase_noaspectTime: ✅ 269.912µs (SLO: <400.000µs 📉 -32.5%) vs baseline: -1.6% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.3% ✅ title_aspectTime: ✅ 318.755µs (SLO: <500.000µs 📉 -36.2%) vs baseline: -2.9% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.5% ✅ title_noaspectTime: ✅ 257.042µs (SLO: <400.000µs 📉 -35.7%) vs baseline: -1.8% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.4% ✅ translate_aspectTime: ✅ 495.642µs (SLO: <700.000µs 📉 -29.2%) vs baseline: -1.6% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% ✅ translate_noaspectTime: ✅ 424.770µs (SLO: <500.000µs 📉 -15.0%) vs baseline: -1.5% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.5% ✅ upper_aspectTime: ✅ 293.080µs (SLO: <500.000µs 📉 -41.4%) vs baseline: -1.3% Memory: ✅ 42.880MB (SLO: <46.000MB -6.8%) vs baseline: +4.2% ✅ upper_noaspectTime: ✅ 236.402µs (SLO: <400.000µs 📉 -40.9%) vs baseline: +0.2% Memory: ✅ 42.900MB (SLO: <46.000MB -6.7%) vs baseline: +4.2% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 512.503µs (SLO: <700.000µs 📉 -26.8%) vs baseline: 📈 +19.6% Memory: ✅ 42.566MB (SLO: <46.000MB -7.5%) vs baseline: +4.3% ✅ ospathbasename_noaspectTime: ✅ 430.018µs (SLO: <700.000µs 📉 -38.6%) vs baseline: -0.8% Memory: ✅ 42.546MB (SLO: <46.000MB -7.5%) vs baseline: +4.4% ✅ ospathjoin_aspectTime: ✅ 630.978µs (SLO: <700.000µs -9.9%) vs baseline: +0.9% Memory: ✅ 42.546MB (SLO: <46.000MB -7.5%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 629.350µs (SLO: <700.000µs 📉 -10.1%) vs baseline: -1.1% Memory: ✅ 42.664MB (SLO: <46.000MB -7.3%) vs baseline: +4.3% ✅ ospathnormcase_aspectTime: ✅ 348.781µs (SLO: <700.000µs 📉 -50.2%) vs baseline: -0.8% Memory: ✅ 42.566MB (SLO: <46.000MB -7.5%) vs baseline: +4.3% ✅ ospathnormcase_noaspectTime: ✅ 359.820µs (SLO: <700.000µs 📉 -48.6%) vs baseline: -0.5% Memory: ✅ 42.664MB (SLO: <46.000MB -7.3%) vs baseline: +4.7% ✅ ospathsplit_aspectTime: ✅ 490.044µs (SLO: <700.000µs 📉 -30.0%) vs baseline: -0.8% Memory: ✅ 42.546MB (SLO: <46.000MB -7.5%) vs baseline: +4.0% ✅ ospathsplit_noaspectTime: ✅ 499.687µs (SLO: <700.000µs 📉 -28.6%) vs baseline: -0.3% Memory: ✅ 42.546MB (SLO: <46.000MB -7.5%) vs baseline: +3.9% ✅ ospathsplitdrive_aspectTime: ✅ 374.493µs (SLO: <700.000µs 📉 -46.5%) vs baseline: +0.9% Memory: ✅ 42.566MB (SLO: <46.000MB -7.5%) vs baseline: +4.4% ✅ ospathsplitdrive_noaspectTime: ✅ 72.338µs (SLO: <700.000µs 📉 -89.7%) vs baseline: -0.6% Memory: ✅ 42.487MB (SLO: <46.000MB -7.6%) vs baseline: +4.0% ✅ ospathsplitext_aspectTime: ✅ 457.635µs (SLO: <700.000µs 📉 -34.6%) vs baseline: +0.4% Memory: ✅ 42.625MB (SLO: <46.000MB -7.3%) vs baseline: +4.3% ✅ ospathsplitext_noaspectTime: ✅ 464.854µs (SLO: <700.000µs 📉 -33.6%) vs baseline: +0.2% Memory: ✅ 42.605MB (SLO: <46.000MB -7.4%) vs baseline: +4.4% 🟡 Near SLO Breach (1 suite)🟡 tracer - 6/6✅ largeTime: ✅ 31.531ms (SLO: <32.950ms -4.3%) vs baseline: +0.6% Memory: ✅ 36.746MB (SLO: <39.250MB -6.4%) vs baseline: +4.5% ✅ mediumTime: ✅ 3.107ms (SLO: <3.200ms -2.9%) vs baseline: +0.7% Memory: ✅ 35.507MB (SLO: <38.750MB -8.4%) vs baseline: +4.9% ✅ smallTime: ✅ 363.016µs (SLO: <370.000µs 🟡 -1.9%) vs baseline: +4.6% Memory: ✅ 35.566MB (SLO: <38.750MB -8.2%) vs baseline: +4.5%
|
Description
When upgrading
libdatadog,pip install -v -e .on macOS can fail with errors like:unknown type name 'ddog_prof_StringId2'Root cause: newer generated headers may reference profiling handle aliases from
common.hbefore those aliases are declared, whileprofiling.hprovides the stable include contract forddog_prof_*APIs.Testing
Risks
Additional Notes