perf(profiling): cache lasti→line per way to skip parse_linetable on …#18435
Draft
vlad-scherbich wants to merge 3 commits into
Draft
perf(profiling): cache lasti→line per way to skip parse_linetable on …#18435vlad-scherbich wants to merge 3 commits into
vlad-scherbich wants to merge 3 commits into
Conversation
…hot allocation sites
Contributor
|
Contributor
|
Isn't there a frame cache similar to the one used by Echion? 🤔 |
Codeowners resolved as |
…ia std::optional std::optional<CacheHit> is 24B on x86-64, which exceeds the 16B register-return threshold and forces the compiler to use a hidden pointer and stack copy on every lookup call. PR2's optional<function_id> was 16B and returned in RAX:RDX. Drop the optional wrapper and use a sentinel line=-1 for lasti mismatch, keeping sizeof(CacheHit)=16B and restoring register return.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hot allocation sites
Description
Testing
Risks
Additional Notes