Skip to content

chore: bump bytecode pin#18438

Open
P403n1x87 wants to merge 4 commits into
mainfrom
chore/bump-bytecode-pin
Open

chore: bump bytecode pin#18438
P403n1x87 wants to merge 4 commits into
mainfrom
chore/bump-bytecode-pin

Conversation

@P403n1x87
Copy link
Copy Markdown
Contributor

Description

We bump the dependency pin on bytecode to ensure that the version with all the most recent fixes is installed alongside ddtrace. We also include regression tests for the fix we are bringing in with the new version.

We bump the dependency pin on bytecode to ensure that the version with
all the most recent fixes is installed alongside ddtrace. We also
include regression tests for the fix we are bringing in with the new
version.
@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 3, 2026
Copy link
Copy Markdown
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix and release note?

Seems might be ok without, since folks should start to pick up the new bytecode version, but we do add fail safe handling here too

@datadog-datadog-prod-us1-2
Copy link
Copy Markdown
Contributor

datadog-datadog-prod-us1-2 Bot commented Jun 3, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 10 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64, 1]   View in Datadog   GitLab

See error Dependency manager download failed: invalid directive in requirements file caused by 'bytecode==0.18.1'.

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741491-d2b8243-musllinux_1_2_x86_64, 1]   View in Datadog   GitLab

See error NotImplementedError: This version of CPython is not supported yet during ddtrace import.

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1]   View in Datadog   GitLab

See error NotImplementedError: This version of CPython is not supported yet while importing ddtrace.

View all 10 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 1 job - 1 passed on retry View in Datadog

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2c82ef9 | Docs | Datadog PR Page | Give us feedback!

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented Jun 3, 2026

Codeowners resolved as

scripts/integration_registry/registry.yaml                              @DataDog/apm-core-python @DataDog/apm-idm-python
supported_versions_output.json                                          @DataDog/apm-core-python @DataDog/apm-idm-python
supported_versions_table.csv                                            @DataDog/apm-core-python @DataDog/apm-idm-python

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jun 3, 2026

Benchmarks

Benchmark execution time: 2026-06-04 11:32:19

Comparing candidate commit 2c82ef9 in PR branch chore/bump-bytecode-pin with baseline commit 8bbc564 in branch main.

Found 0 performance improvements and 5 performance regressions! Performance is the same for 617 metrics, 10 unstable metrics.

scenario:iastaspects-index_aspect

  • 🟥 execution_time [+19.913µs; +23.518µs] or [+16.141%; +19.063%]

scenario:iastaspects-title_aspect

  • 🟥 execution_time [+46.374µs; +52.380µs] or [+14.067%; +15.888%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+111.218µs; +118.684µs] or [+25.996%; +27.741%]

scenario:span-start

  • 🟥 execution_time [+1.144ms; +1.294ms] or [+7.330%; +8.292%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+163.542ns; +201.537ns] or [+7.710%; +9.502%]

@P403n1x87 P403n1x87 marked this pull request as ready for review June 3, 2026 15:53
@P403n1x87 P403n1x87 requested review from a team as code owners June 3, 2026 15:53
@P403n1x87 P403n1x87 requested review from dubloom and emmettbutler June 3, 2026 15:53
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de50caf8f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ddtrace/internal/wrapping/context.py Outdated
Copy link
Copy Markdown
Collaborator

@emmettbutler emmettbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense I suppose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants