Skip to content

perf(profiling): reduce profiler arena memory footprint#18469

Draft
taegyunkim wants to merge 1 commit into
mainfrom
taegyunkim/prof-14423-reduce-profiler-arena
Draft

perf(profiling): reduce profiler arena memory footprint#18469
taegyunkim wants to merge 1 commit into
mainfrom
taegyunkim/prof-14423-reduce-profiler-arena

Conversation

@taegyunkim
Copy link
Copy Markdown
Contributor

Description

Pins the src/native libdatadog dependencies to commit 45a451cd8fddfc479cb9357a0602e146016dc8db from DataDog/libdatadog#2048 to pick up the profiler arena memory-footprint reduction.

This also adapts the tracer flare native wrapper to the libdatadog remote-config parser registry API, which replaces RemoteConfigData with parsed product data returned by default_registry().parse(...).

Testing

  • cd src/native && cargo check --features profiling
  • scripts/run-tests --venv 803a341 tests/internal/test_tracer_flare_native.py -- -- tests/internal/test_tracer_flare_native.py -q
  • scripts/run-tests --venv 803a341 tests/internal/test_tracer_flare.py -- -- tests/internal/test_tracer_flare.py::TracerFlareSubscriberTests::test_configuration_order_payload_is_skipped tests/internal/test_tracer_flare.py::TracerFlareSubscriberTests::test_process_flare_request_success -q
  • scripts/lint fmt setup.py
  • scripts/lint spelling releasenotes/notes/profiling-libdatadog-reduce-profiler-arena-d781a459638124bd.yaml
  • git diff --check

Risks

Additional Notes

Native review evidence:

  • Build/release: cargo check --features profiling compiled the native crate against the new libdatadog pin; targeted native flare tests passed on Python 3.12.
  • Version awareness: verified 45a451cd8fddfc479cb9357a0602e146016dc8db is the current head of perf(profiling): reduce profiler arena memory footprint libdatadog#2048 and adapted to the pinned commit's remote-config API.
  • Local profiler memory benchmarks were not run; expected profiler memory impact comes from the upstream libdatadog PR.

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Codeowners resolved as

releasenotes/notes/profiling-libdatadog-reduce-profiler-arena-d781a459638124bd.yaml  @DataDog/apm-python
setup.py                                                                @DataDog/python-guild
src/native/Cargo.lock                                                   @DataDog/apm-core-python
src/native/Cargo.toml                                                   @DataDog/apm-core-python
src/native/tracer_flare.rs                                              @DataDog/apm-core-python

@datadog-prod-us1-3
Copy link
Copy Markdown

datadog-prod-us1-3 Bot commented Jun 4, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 8 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64, 1]   View in Datadog   GitLab

See error Missing entries in dependencies configuration file for the 'bytecode' package.

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741491-d2b8243-musllinux_1_2_x86_64, 1]   View in Datadog   GitLab

See error NotImplementedError: This version of CPython is not supported yet

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1]   View in Datadog   GitLab

See error NotImplementedError: This version of CPython is not supported yet during imports.

View all 8 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 30dd566 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jun 4, 2026

Benchmarks

Benchmark execution time: 2026-06-04 18:52:29

Comparing candidate commit 30dd566 in PR branch taegyunkim/prof-14423-reduce-profiler-arena with baseline commit 58ac3af in branch main.

Found 0 performance improvements and 5 performance regressions! Performance is the same for 615 metrics, 10 unstable metrics.

scenario:iastaspects-index_aspect

  • 🟥 execution_time [+14.358µs; +17.403µs] or [+11.912%; +14.438%]

scenario:iastaspects-title_aspect

  • 🟥 execution_time [+40.970µs; +49.701µs] or [+12.511%; +15.177%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+91.531µs; +101.657µs] or [+20.990%; +23.312%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+11.441µs; +14.517µs] or [+7.572%; +9.608%]

scenario:span-start

  • 🟥 execution_time [+1.465ms; +1.656ms] or [+9.433%; +10.663%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant