-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEBUG-3317 report probe status errored if probe fails to instrument #4301
Conversation
spec/datadog/di/integration/everything_from_remote_config_spec.rb
Outdated
Show resolved
Hide resolved
spec/datadog/di/integration/everything_from_remote_config_spec.rb
Outdated
Show resolved
Hide resolved
Datadog ReportBranch report: ✅ 0 Failed, 22092 Passed, 1477 Skipped, 5m 8.94s Total Time |
BenchmarksBenchmark execution time: 2025-01-27 20:55:18 Comparing candidate commit b1d052c in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics. scenario:profiler - gvl benchmark samples
scenario:tracing - Propagation - Datadog
scenario:tracing - Tracing.log_correlation
|
91a1c3a
to
b0f954d
Compare
…d but not in code tracker registry
b0f954d
to
4be8c62
Compare
Datadog ReportBranch report: ✅ 0 Failed, 22105 Passed, 1477 Skipped, 5m 27.86s Total Time |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4301 +/- ##
==========================================
- Coverage 97.72% 97.71% -0.01%
==========================================
Files 1368 1368
Lines 82916 82997 +81
Branches 4209 4219 +10
==========================================
+ Hits 81027 81102 +75
- Misses 1889 1895 +6 ☔ View full report in Codecov by Sentry. |
What does this PR do?
Reports probe status as errored if the probe fails to instrument.
Motivation:
Manual testing revealed that failure to instrument due to code not being in code tracker did not update UI with probe status.
Change log entry
Yes: fix UI notifications when dynamic instrumentation probes fail to instrument
Additional Notes:
How to test the change?
Tests are included