Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG-3317 report probe status errored if probe fails to instrument #4301

Merged
merged 14 commits into from
Jan 27, 2025

Conversation

p-datadog
Copy link
Member

What does this PR do?

Reports probe status as errored if the probe fails to instrument.

Motivation:

Manual testing revealed that failure to instrument due to code not being in code tracker did not update UI with probe status.

Change log entry
Yes: fix UI notifications when dynamic instrumentation probes fail to instrument

Additional Notes:

How to test the change?

Tests are included

@p-datadog p-datadog requested a review from a team as a code owner January 16, 2025 21:43
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 16, 2025

Datadog Report

Branch report: di-not-in-registry-integration-test
Commit report: b0f954d
Test service: dd-trace-rb

✅ 0 Failed, 22092 Passed, 1477 Skipped, 5m 8.94s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2025

Benchmarks

Benchmark execution time: 2025-01-27 20:55:18

Comparing candidate commit b1d052c in PR branch di-not-in-registry-integration-test with baseline commit 494e0e1 in branch master.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics.

scenario:profiler - gvl benchmark samples

  • 🟩 throughput [+583.017op/s; +592.461op/s] or [+5.290%; +5.375%]

scenario:tracing - Propagation - Datadog

  • 🟩 throughput [+2820.341op/s; +2896.843op/s] or [+9.397%; +9.652%]

scenario:tracing - Tracing.log_correlation

  • 🟩 throughput [+5648.617op/s; +5992.537op/s] or [+5.064%; +5.372%]

@p-datadog p-datadog force-pushed the di-not-in-registry-integration-test branch from 91a1c3a to b0f954d Compare January 22, 2025 19:23
@p-datadog p-datadog force-pushed the di-not-in-registry-integration-test branch from b0f954d to 4be8c62 Compare January 27, 2025 16:48
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 27, 2025

Datadog Report

Branch report: di-not-in-registry-integration-test
Commit report: b1d052c
Test service: dd-trace-rb

✅ 0 Failed, 22105 Passed, 1477 Skipped, 5m 27.86s Total Time

@p-datadog p-datadog merged commit 6cdf92e into master Jan 27, 2025
378 checks passed
@p-datadog p-datadog deleted the di-not-in-registry-integration-test branch January 27, 2025 20:57
@github-actions github-actions bot added this to the 2.10.0 milestone Jan 27, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.87755% with 6 lines in your changes missing coverage. Please review.

Project coverage is 97.71%. Comparing base (494e0e1) to head (b1d052c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
spec/datadog/di/spec_helper.rb 50.00% 5 Missing ⚠️
...egration/instrumentation_integration_test_class.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4301      +/-   ##
==========================================
- Coverage   97.72%   97.71%   -0.01%     
==========================================
  Files        1368     1368              
  Lines       82916    82997      +81     
  Branches     4209     4219      +10     
==========================================
+ Hits        81027    81102      +75     
- Misses       1889     1895       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants