Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test with swallowed errors #4317

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix test with swallowed errors #4317

wants to merge 1 commit into from

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jan 23, 2025

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Jan 23, 2025
Copy link

👋 Hey @marcotc, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-01-23 23:53:29 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: warn-test
Commit report: 908f73c
Test service: dd-trace-rb

✅ 0 Failed, 22012 Passed, 1477 Skipped, 5m 11.86s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (84ca739) to head (908f73c).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4317      +/-   ##
==========================================
- Coverage   97.72%   97.72%   -0.01%     
==========================================
  Files        1365     1365              
  Lines       82727    82730       +3     
  Branches     4205     4205              
==========================================
+ Hits        80846    80848       +2     
- Misses       1881     1882       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 24, 2025

Benchmarks

Benchmark execution time: 2025-01-24 00:15:51

Comparing candidate commit 908f73c in PR branch warn-test with baseline commit 84ca739 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants