Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPSEC-56683] Add appsec.auto_user_instrumentation.mode setting #4352

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Strech
Copy link
Member

@Strech Strech commented Feb 6, 2025

What does this PR do?

Adds a new customer-facing setting for AppSec which is suppose to replace existing deprecated option. It will take precedence over existing setting and have different values.

Motivation:

This is a part of the automated user tracking functionality.

Change log entry

Yes. TO BE DONE

Additional Notes:

This setting immediately will be incorporated into existing code, so it will be fine to release it without an additional functionality.

How to test the change?

CI should be enough

@github-actions github-actions bot added the appsec Application Security monitoring product label Feb 6, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 6, 2025

Datadog Report

Branch report: appsec-56683-update-auto-user-instrumentation-mode-configuration
Commit report: 6d78f43
Test service: dd-trace-rb

✅ 0 Failed, 22094 Passed, 1476 Skipped, 6m 30.35s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 94.79167% with 5 lines in your changes missing coverage. Please review.

Project coverage is 97.72%. Comparing base (a70cf66) to head (6d78f43).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...ib/devise/patcher/registration_controller_patch.rb 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4352      +/-   ##
==========================================
- Coverage   97.72%   97.72%   -0.01%     
==========================================
  Files        1368     1368              
  Lines       82998    83090      +92     
  Branches     4220     4224       +4     
==========================================
+ Hits        81113    81200      +87     
- Misses       1885     1890       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Feb 6, 2025

Benchmarks

Benchmark execution time: 2025-02-06 21:19:59

Comparing candidate commit 6d78f43 in PR branch appsec-56683-update-auto-user-instrumentation-mode-configuration with baseline commit a70cf66 in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:profiler - Allocations ()

  • 🟥 throughput [-467298.939op/s; -461037.790op/s] or [-13.977%; -13.789%]

scenario:profiler - sample timeline=false

  • 🟩 throughput [+0.463op/s; +0.471op/s] or [+7.676%; +7.816%]

@Strech Strech force-pushed the appsec-56683-update-auto-user-instrumentation-mode-configuration branch from 1b6e5a2 to 6d78f43 Compare February 6, 2025 20:56
@github-actions github-actions bot added the integrations Involves tracing integrations label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants