[PROF-9476] Revert "Temporary disable benchmark to make CI happy" #4376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This reverts commit 569bf56. **Motivation:** We temporarily disabled this benchmark in #4331 for the reasons explained in the comment. Once that PR is in master we can re-enable the benchmark. **Additional Notes:** This sharp edge of our benchmarks setup is annoying, but I'll fight it another day... **How to test the change?** Validate this benchmark is now running in the benchmarking platform results page.
ivoanjo
added
dev/testing
Datadog ReportBranch report: ✅ 0 Failed, 22084 Passed, 1477 Skipped, 6m 17.94s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ivoanjo/prof-9476-managed-string-storage-try2 #4376 +/- ##
=================================================================================
- Coverage 97.75% 97.74% -0.02%
=================================================================================
Files 1351 1351
Lines 82729 82679 -50
Branches 4202 4197 -5
=================================================================================
- Hits 80872 80814 -58
- Misses 1857 1865 +8 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2025-02-13 10:51:21 Comparing candidate commit ec699eb in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 33 metrics, 2 unstable metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This reverts commit 569bf56.
Motivation:
We temporarily disabled this benchmark in
#4331
for the reasons explained in the comment.
Once that PR is in master we can re-enable the benchmark.
Change log entry
None.
Additional Notes:
This sharp edge of our benchmarks setup is annoying, but I'll fight it another day...
How to test the change?
Validate this benchmark is now running in the benchmarking platform results page.