-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adapt RUM server onboarding to include httpd #27435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview links (active after the
|
f0af487
to
1a5efc0
Compare
1a5efc0
to
bd5e9bf
Compare
Does HTTPD support allowedTracingUrls and excludedActivityUrls? If so we should edit the NGINX line to include HTTPD |
There's a paragraph towards the bottom of the page that says: Content compression by upstream server: If NGINX is acting as a proxy and the upstream server has content compression (like gzip, zstd, or Brotli) enabled, the module may not inject RUM. Ensure that content compression is disabled on the upstream server and configure NGINX to compress the content. Should this be just NGINX or any of the webservers? |
Created DOCS-10037 for more in-depth review. |
It applies to all because they can all be configured as reverse proxies. It also feels redundant with the section above that reads "If proxying compressed traffic...". WGDYT @rtrieu ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback for your review. But otherwise looks good!
I think you are right that this is repetitive. I'll push a commit with a suggestion to reconcile these two. |
Co-authored-by: Rosa Trieu <[email protected]>
Co-authored-by: Rosa Trieu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few suggestions. Thank you @rtrieu.
Co-authored-by: Aymeric <[email protected]> Co-authored-by: Damien Mehala <[email protected]>
Co-authored-by: Damien Mehala <[email protected]>
Applying minor suggestions
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The median merge time in
|
Co-authored-by: rtrieu <[email protected]>
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes