Skip to content

Update functions_gen1.md example nodejs function #28786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

piyalibanerjee-dd
Copy link
Contributor

Updated example nodejs function to include the SCL initialization line and to initialize the trace handler prior to invocation.

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

Updated example nodejs function to include the SCL initialization line and to initialize the trace handler prior to invocation.
@piyalibanerjee-dd piyalibanerjee-dd requested review from a team as code owners April 15, 2025 17:02
@aliciascott aliciascott self-assigned this Apr 15, 2025
@aliciascott
Copy link
Contributor

Hi @piyalibanerjee-dd would you mind to close this PR and create a new one with the correct branch naming convention?

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview.

@aliciascott
Copy link
Contributor

Hi @piyalibanerjee-dd for now since this is a very minor change I can go ahead and approve and merge this, but going forward, if you don't mind creating your branches with the / naming convention, thanks!

@aliciascott aliciascott merged commit 27cb0c0 into master Apr 21, 2025
15 of 16 checks passed
@aliciascott aliciascott deleted the piyalibanerjee-dd-patch-1 branch April 21, 2025 15:52
estherk15 pushed a commit that referenced this pull request May 8, 2025
Updated example nodejs function to include the SCL initialization line and to initialize the trace handler prior to invocation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants