Custom Framework API Spec #28798
Merged
Custom Framework API Spec #28798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![api-clients-generation-pipeline[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
api-clients-generation-pipeline
bot
requested a review
from a team
as a code owner
aliciascott
requested changes
Apr 16, 2025
There was a problem hiding this comment.
Hi @nkonjeti there are some formatting snafu's that need fixed along with requested changes in https://github.com/DataDog/datadog-api-spec/pull/3739.
Let me know once fixed and we can re-review. Thanks!
data/api/v2/full_spec.yaml
Outdated
| origin: request | ||
| source: data.attributes.version | ||
| type: unsafe | ||
| x-unstable: '**Note**: This endpoint is in beta and may be subject to changes. |
There was a problem hiding this comment.
Suggested change
| x-unstable: '**Note**: This endpoint is in beta and may be subject to changes. | |
| x-unstable: **Note**: This endpoint is in Preview and may be subject to changes. |
data/api/v2/full_spec.yaml
Outdated
| type: unsafe | ||
| x-unstable: '**Note**: This endpoint is in beta and may be subject to changes. | ||
|
|
||
| Please check the documentation regularly for updates.' |
There was a problem hiding this comment.
Suggested change
| Please check the documentation regularly for updates.' | |
| Please check the documentation regularly for updates. |
data/api/v2/full_spec.yaml
Outdated
| - security_monitoring_rules_write | ||
| x-undo: | ||
| type: idempotent | ||
| x-unstable: '**Note**: This endpoint is in beta and may be subject to changes. |
There was a problem hiding this comment.
Suggested change
| x-unstable: '**Note**: This endpoint is in beta and may be subject to changes. | |
| x-unstable: **Note**: This endpoint is in beta and may be subject to changes. |
data/api/v2/full_spec.yaml
Outdated
| - security_monitoring_rules_write | ||
| x-undo: | ||
| type: idempotent | ||
| x-unstable: '**Note**: This endpoint is in beta and may be subject to changes. |
There was a problem hiding this comment.
Suggested change
| x-unstable: '**Note**: This endpoint is in beta and may be subject to changes. | |
| x-unstable: **Note**: This endpoint is in beta and may be subject to changes. |
data/api/v2/full_spec.yaml
Outdated
| type: idempotent | ||
| x-unstable: '**Note**: This endpoint is in beta and may be subject to changes. | ||
|
|
||
| Please check the documentation regularly for updates.' |
There was a problem hiding this comment.
Suggested change
| Please check the documentation regularly for updates.' | |
| Please check the documentation regularly for updates. |
data/api/v2/full_spec_deref.json
Outdated
| } | ||
| "type": "idempotent" | ||
| }, | ||
| "x-unstable": "**Note**: This endpoint is in beta and may be subject to changes.\nPlease check the documentation regularly for updates." |
There was a problem hiding this comment.
Suggested change
| "x-unstable": "**Note**: This endpoint is in beta and may be subject to changes.\nPlease check the documentation regularly for updates." | |
| "x-unstable": **Note**: This endpoint is in Preview and may be subject to changes.\nPlease check the documentation regularly for updates." |
data/api/v2/full_spec_deref.json
Outdated
| ], | ||
| "type": "unsafe" | ||
| }, | ||
| "x-unstable": "**Note**: This endpoint is in beta and may be subject to changes.\nPlease check the documentation regularly for updates." |
There was a problem hiding this comment.
Suggested change
| "x-unstable": "**Note**: This endpoint is in beta and may be subject to changes.\nPlease check the documentation regularly for updates." | |
| "x-unstable": **Note**: This endpoint is in beta and may be subject to changes.\nPlease check the documentation regularly for updates." |
data/api/v2/full_spec_deref.json
Outdated
| "x-undo": { | ||
| "type": "idempotent" | ||
| }, | ||
| "x-unstable": "**Note**: This endpoint is in beta and may be subject to changes.\nPlease check the documentation regularly for updates." |
There was a problem hiding this comment.
Suggested change
| "x-unstable": "**Note**: This endpoint is in beta and may be subject to changes.\nPlease check the documentation regularly for updates." | |
| "x-unstable": **Note**: This endpoint is in beta and may be subject to changes.\nPlease check the documentation regularly for updates." |
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3739
branch
from
cef2bb3 to
bf2b140
Compare
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3739
branch
13 times, most recently
from
cca0147 to
5496930
Compare
aliciascott
approved these changes
Apr 28, 2025
| "json": { | ||
| "data": { | ||
| "attributes": { | ||
| "description": "this is an example description", |
There was a problem hiding this comment.
Suggested change
| "description": "this is an example description", | |
| "description": "this is an example description", |
Small suggestion, should this be filled out with the actual description ?
There was a problem hiding this comment.
oh the description was "this is an example description" I will try to think of a better example
There was a problem hiding this comment.
ok thanks for the context there! I think this is probably fine, I was just missing the context.
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3739
branch
from
5496930 to
b80f645
Compare
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3739
branch
from
b80f645 to
4bf4fd4
Compare
api-clients-generation-pipeline
bot
deleted the
datadog-api-spec/generated/3739
branch
estherk15
pushed a commit
that referenced
this pull request
May 8, 2025
Co-authored-by: ci.datadog-api-spec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#3739
Test branch datadog-api-spec/test/vbarth/neha.konjeti/custom-framework