Skip to content

Update java.md for dd.jdk.socket.enabled config option #29182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

sarahchen6
Copy link
Contributor

What does this PR do? What is the motivation?

Add the dd.jdk.socket.enabled option from this PR to our documentation.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

Not sure if this config option should be included in a pre-existing sub-section of the docs, or if the designated UDS sub-section can be better named. Open to suggestions - thanks!

@sarahchen6 sarahchen6 marked this pull request as ready for review May 6, 2025 17:34
@sarahchen6 sarahchen6 requested a review from a team as a code owner May 6, 2025 17:34
Copy link
Contributor

github-actions bot commented May 6, 2025

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to /merge if this is ready to go.

@sarahchen6
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 6, 2025

View all feedbacks in Devflow UI.

2025-05-06 18:26:28 UTC ℹ️ Start processing command /merge


2025-05-06 18:26:34 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 22m (p90).


2025-05-06 18:44:30 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 641e622 into master May 6, 2025
17 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the sarahchen6/add-jdk-uds-config branch May 6, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants