Skip to content

Fix ToC incorrect highlight and search input text overlap [WEB-9223] #37256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StefonSimmons wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −3
Open

Fix ToC incorrect highlight and search input text overlap [WEB-9223] #37256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec5ccec
handle hidden headings. preventing them from being highlighted in the…
StefonSimmons Jun 3, 2026
720d057
Add padding-right to SearchBox input as to prevent input text overlap
StefonSimmons Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions assets/scripts/components/table-of-contents.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,14 @@ export function onScroll() {
const windowTopPosition = scrollTop(window);
const windowHeight = window.innerHeight;
let localOffset = 65;


const getHeaderTop = (header) => {
// Treat hidden headings (e.g. display:none) as being below the
// scroll-spy threshold so they are never active/highlighted in TOC.
const rect = header.getBoundingClientRect();
return rect.height === 0 && rect.width === 0 ? (localOffset+1) : rect.top;
}

const isCustomizableDoc = document.getElementById('cdoc-selector') ? true : false;
if (isCustomizableDoc) {
localOffset += 65;
Expand Down Expand Up @@ -147,9 +154,9 @@ export function onScroll() {

if (
windowTopPosition !== 0 &&
sideNavItem.header.getBoundingClientRect().top <= 0 + localOffset &&
getHeaderTop(sideNavItem.header) <= localOffset &&
(typeof nextSideNavItem === 'undefined' ||
nextSideNavItem.header.getBoundingClientRect().top > 0 + localOffset)
getHeaderTop(nextSideNavItem.header) > localOffset)
) {
sideNavItem.navLink.classList.add('toc_scrolled');
// Add toc open to parents of this toc_scrolled
Expand Down
1 change: 1 addition & 0 deletions assets/styles/instantsearch/search-page.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

.ais-SearchBox-input {
background-color: #e6e6e6;
padding-right: 30px;
}

#count {
Expand Down
1 change: 1 addition & 0 deletions assets/styles/instantsearch/searchbar-with-dropdown.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
.ais-SearchBox-input {
font-feature-settings: 'lnum' 1;
padding-left: 9px;
padding-right: 30px;
margin-right: 8px;

&:focus-visible {
Expand Down
Loading