-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USM: Expose configuration options of USM #1705
base: main
Are you sure you want to change the base?
Conversation
1363f1b
to
0f8fc6b
Compare
0f8fc6b
to
d059ca4
Compare
enable_http2_monitoring: {{ $.Values.datadog.serviceMonitoring.http2MonitoringEnabled }} | ||
{{- end }} | ||
tls: | ||
{{- if not (eq .Values.datadog.serviceMonitoring.tls.go.enabled nil) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we need to use the default values in the agent? It just seems a little odd setting bool value defaults as nil
. It seems like this has only been done once in the helm chart before.
Can we just set the defaults we want in values.yaml and avoid all the conditional logic and defaulting booleans to nil? Don't know if your approach is wrong per say, just seems strange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we need to use the default values in the agent?
Yes, some features have been enabled by default over time.
- We don’t want the Helm chart to be the source of truth for determining which features are enabled by default.
- The Helm chart version and the agent version are independent—updating one does not necessarily mean using the latest of the other. Therefore, we prefer to rely on the agent's version.
- Our goal is to provide a simple experience for customers while still allowing them to enable additional features or disable defaults as needed.
What this PR does / why we need it:
Add multiple configuration options of USM, to allow easy configuration for customer.
Default values are intentionally kept as nil, to allow the using the agent's default values unless the customer explicitly modified the option.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Testing:
Use agent default values
Install
helm install datadog-agent -f datadog-values.yaml
Run
k exec -it -n datadog-agent -c system-probe daemonset.apps/datadog-agent -- system-probe config show
Expect to see
Enable everything
Install
helm install datadog-agent -f datadog-values.yaml
Run
k exec -it -n datadog-agent -c system-probe daemonset.apps/datadog-agent -- system-probe config show
Expect to see
Disable everything
Install
helm install datadog-agent -f datadog-values.yaml
Run
k exec -it -n datadog-agent -c system-probe daemonset.apps/datadog-agent -- system-probe config show
Expect to see
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh
)CHANGELOG.md
has been updatedREADME.md
make update-test-baselines
)