Ignore metrics read over prometheus with NaN value #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blt
approved these changes
Feb 4, 2025
scottopell
reviewed
Feb 4, 2025
Signed-off-by: Caleb Metz <[email protected]>
Signed-off-by: Caleb Metz <[email protected]>
cmetz100
force-pushed
the
cmetz/ignore_null_in_prometheous_scraping
branch
from
e33d9c4 to
4dff200
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ignores counters and guages scraped over prometheus that have a NaN value.
Motivation
Turns out NaN is a valid constant of f64 so when we scrape prometheus endpoint and read a NaN value we try to set it as a gauge or counter. This is then translated to null in the capture file. null in the capture file causes
rouster-series-senderto fail when submitting metricsRelated issues
I am not 100% confident that this is all we need to handle all edges regarding NaN