Repository navigation
Add flush_every config option to BufWriter generators - #1683
Merged
Merged
Conversation
Contributor
Author
This was referenced Jan 6, 2026
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
January 6, 2026 18:50
a2c8d36 to
0e90fb1
Compare
TheSafo
changed the base branch from
jsaf/block-based-limiter
to
graphite-base/1683
January 6, 2026 21:00
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
January 6, 2026 21:24
0e90fb1 to
b69f29c
Compare
TheSafo
force-pushed
the
graphite-base/1683
branch
from
January 6, 2026 21:24
9ae8ce6 to
648642c
Compare
TheSafo
changed the base branch from
graphite-base/1683
to
jsaf/block-based-limiter
January 6, 2026 21:24
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
January 6, 2026 21:46
648642c to
a636e4c
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
January 6, 2026 21:46
b69f29c to
403c48a
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
January 6, 2026 21:58
403c48a to
e13d903
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
January 6, 2026 21:58
a636e4c to
661d654
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
January 6, 2026 22:13
e13d903 to
a62c9fd
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
2 times, most recently
from
January 6, 2026 22:29
867b097 to
e1d8abc
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
January 6, 2026 22:29
a62c9fd to
8180361
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
January 6, 2026 22:31
e1d8abc to
e73bb21
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
January 6, 2026 22:31
8180361 to
899bfeb
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
2 times, most recently
from
January 7, 2026 14:34
886980b to
8071239
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
January 15, 2026 21:34
e73bb21 to
57bce08
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
January 15, 2026 21:34
8071239 to
ff8a57f
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
January 15, 2026 21:35
57bce08 to
a47d241
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
January 15, 2026 21:35
ff8a57f to
1be6e74
Compare
TheSafo
marked this pull request as ready for review
January 16, 2026 18:13
blt
reviewed
Jan 20, 2026
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
January 21, 2026 15:48
a47d241 to
88ac56e
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
2 times, most recently
from
January 21, 2026 18:03
30363c3 to
4aba943
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
January 21, 2026 18:03
88ac56e to
1692f26
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
2 times, most recently
from
February 9, 2026 15:24
b413062 to
85dfb43
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
March 5, 2026 15:52
85dfb43 to
fac862b
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
March 5, 2026 15:59
fac862b to
c5eee9b
Compare
blt
reviewed
Mar 5, 2026
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
March 5, 2026 16:21
c5eee9b to
8e1b11c
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
March 5, 2026 16:38
8e1b11c to
84e040f
Compare
blt
approved these changes
Mar 5, 2026
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
March 12, 2026 15:50
84e040f to
d697f76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Adds flush_every duration config to traditional and logrotate generators. This ensures that blocks get flushed periodically not just when the bufffer is full.
Motivation
BufWriter generally only writes out to disk once its capacity is full (or on log rotate). For standard usage of lading, this works fine since the capacity is set at the maximum throttler capacity (in bytes), which lading trires its best to run at, so it flushes ~every second. However, for block-based throttling (and varying block sizes) it's less likely that 1 second of blocks fills the maximum possible bytes capacity for those blocks (blocks per second times max block size), so having a config option to flush periodically ensures regular flush intervals.
Related issues
Follow up of #1675