Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Julio Gonzalez <[email protected]>
  • Loading branch information
bwoebi and hoolioh authored Jun 24, 2024
1 parent 8316815 commit 98cef5d
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions remote-config/src/dynamic_configuration/data.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use serde::{Deserialize, Serialize};
use std::collections::HashMap;

#[derive(Debug, Deserialize)]
#[cfg_attr(feature = "test", derive(Serialize))]
#[cfg_attr(feature = "test", derive(Default, Serialize))]
pub struct DynamicConfigTarget {
pub service: String,
pub env: String,
Expand Down Expand Up @@ -106,10 +106,7 @@ pub mod tests {
pub fn dummy_dynamic_config(enabled: bool) -> DynamicConfigFile {
DynamicConfigFile {
action: "".to_string(),
service_target: DynamicConfigTarget {
service: "".to_string(),
env: "".to_string(),
},
service_target: DynamicConfigTarget::default(),
lib_config: DynamicConfig {
tracing_enabled: Some(enabled),
..DynamicConfig::default()
Expand Down

0 comments on commit 98cef5d

Please sign in to comment.