ci: verify nextest download integrity in CentOS7 image#1973
Draft
paullegranddc wants to merge 1 commit into
Draft
ci: verify nextest download integrity in CentOS7 image#1973paullegranddc wants to merge 1 commit into
paullegranddc wants to merge 1 commit into
Conversation
Contributor
📚 Documentation Check Results📦
|
Contributor
🔒 Cargo Deny Results📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1973 +/- ##
=======================================
Coverage 72.64% 72.64%
=======================================
Files 448 448
Lines 73629 73629
=======================================
Hits 53487 53487
Misses 20142 20142
🚀 New features to boost your workflow:
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 642acd9 | Docs | Datadog PR Page | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
nextestbinary download intools/docker/Dockerfile.centosthat could allow workspace poisoning and later secret exfiltration.Description
curl | tarinstall with downloading the pinned musl tarball to a temporary file intools/docker/Dockerfile.centos.4f98a0f8c0b0f1a335f17d6385b799ec23f953a54358d49358c2a39bd6fd7fa9) and verify it withsha256sum -cbefore extraction./usr/local/binonly after successful verification and remove the downloaded archive to avoid leaving the artifact in the image layer.Testing
tools/docker/Dockerfile.centosand confirmed the file now contains the download+checksum+extract sequence (static verification).sha256sum -cwill fail the Docker build if the digest does not match.Codex Task