Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svls 6036 respect timeouts #851

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Svls 6036 respect timeouts #851

wants to merge 9 commits into from
+120 −75

Conversation

alexgallotta
Copy link
Contributor

this change make the configured flushing time out respected

  • Do not keep trying shipping for each batch if a 500 error is met
  • send sketches and distributions in parallel

@alexgallotta alexgallotta requested a review from a team as a code owner February 3, 2025 22:05
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.55556% with 40 lines in your changes missing coverage. Please review.

Project coverage is 71.90%. Comparing base (7628bcb) to head (845c86b).
Report is 21 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
+ Coverage   71.44%   71.90%   +0.45%     
==========================================
  Files         317      324       +7     
  Lines       46656    48076    +1420     
==========================================
+ Hits        33334    34567    +1233     
- Misses      13322    13509     +187
Components Coverage Δ
crashtracker 43.28% <ø> (+1.01%) ⬆️
crashtracker-ffi 6.30% <ø> (-0.09%) ⬇️
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.36% <ø> (+0.87%) ⬆️
data-pipeline-ffi 91.45% <ø> (+1.36%) ⬆️
ddcommon 80.08% <ø> (-0.54%) ⬇️
ddcommon-ffi 61.05% <ø> (-1.07%) ⬇️
ddtelemetry 61.74% <ø> (+2.23%) ⬆️
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 89.58% <55.55%> (-0.43%) ⬇️
dogstatsd-client 79.77% <ø> (ø)
ipc 82.68% <ø> (ø)
profiling 80.04% <ø> (+1.08%) ⬆️
profiling-ffi 70.68% <ø> (+3.02%) ⬆️
serverless 0.00% <ø> (ø)
sidecar 41.50% <ø> (-0.29%) ⬇️
sidecar-ffi 9.26% <ø> (-1.52%) ⬇️
spawn-worker 54.37% <ø> (ø)
tinybytes 92.79% <ø> (-0.81%) ⬇️
trace-mini-agent 72.48% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.96% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.56% <ø> (-0.60%) ⬇️

astuyve
astuyve reviewed Feb 4, 2025
View reviewed changes
dogstatsd/src/flusher.rs Outdated Show resolved Hide resolved
astuyve
astuyve reviewed Feb 4, 2025
View reviewed changes
dogstatsd/src/flusher.rs Outdated Show resolved Hide resolved
@pr-commenter
Copy link

pr-commenter bot commented Feb 4, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-02-10 18:49:39

Comparing candidate commit 845c86b in PR branch SVLS-6036-respect-timeouts with baseline commit 1a7e673 in branch main.

Found 14 performance improvements and 8 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:benching string interning on wordpress profile

  • 🟩 execution_time [-8.480µs; -8.328µs] or [-5.745%; -5.641%]

scenario:credit_card/is_card_number/ 3782-8224-6310-005

  • 🟩 execution_time [-7.328µs; -7.059µs] or [-7.458%; -7.184%]
  • 🟩 throughput [+789216.924op/s; +818500.239op/s] or [+7.754%; +8.042%]

scenario:credit_card/is_card_number/ 378282246310005

  • 🟩 execution_time [-9.055µs; -8.841µs] or [-9.783%; -9.551%]
  • 🟩 throughput [+1142913.678op/s; +1168691.412op/s] or [+10.578%; +10.817%]

scenario:credit_card/is_card_number/x371413321323331

  • 🟩 execution_time [-399.121ns; -397.678ns] or [-5.833%; -5.812%]
  • 🟩 throughput [+9020049.497op/s; +9053041.062op/s] or [+6.172%; +6.194%]

scenario:credit_card/is_card_number_no_luhn/ 3782-8224-6310-005

  • 🟩 execution_time [-6.381µs; -6.267µs] or [-8.364%; -8.216%]
  • 🟩 throughput [+1174142.377op/s; +1196440.981op/s] or [+8.957%; +9.127%]

scenario:credit_card/is_card_number_no_luhn/x371413321323331

  • 🟩 execution_time [-402.374ns; -400.123ns] or [-5.879%; -5.846%]
  • 🟩 throughput [+9074926.758op/s; +9125699.569op/s] or [+6.211%; +6.245%]

scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...

  • 🟩 execution_time [-29.533µs; -28.591µs] or [-13.689%; -13.253%]
  • 🟩 throughput [+710129.263op/s; +732729.118op/s] or [+15.318%; +15.805%]

scenario:normalization/normalize_name/normalize_name/good

  • 🟥 execution_time [+776.492ns; +799.181ns] or [+5.762%; +5.930%]
  • 🟥 throughput [-4160153.610op/s; -4038908.089op/s] or [-5.606%; -5.443%]

scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...

  • 🟥 execution_time [+272.140µs; +272.573µs] or [+63.336%; +63.437%]
  • 🟥 throughput [-903978.177op/s; -901871.815op/s] or [-38.841%; -38.751%]

scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters

  • 🟥 execution_time [+29.061µs; +29.258µs] or [+17.941%; +18.063%]
  • 🟥 throughput [-944591.884op/s; -938971.192op/s] or [-15.300%; -15.209%]

scenario:normalization/normalize_service/normalize_service/test_ASCII

  • 🟥 execution_time [+6.015µs; +6.072µs] or [+13.946%; +14.078%]
  • 🟥 throughput [-2861286.809op/s; -2837249.694op/s] or [-12.341%; -12.237%]

scenario:sql/obfuscate_sql_string

  • 🟩 execution_time [-7.704µs; -7.622µs] or [-10.024%; -9.918%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 845c86b 1739210166 SVLS-6036-respect-timeouts
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 38.521µs 39.231µs ± 1.225µs 38.674µs ± 0.062µs 38.762µs 41.862µs 41.899µs 43.034µs 11.27% 1.715 1.029 3.11% 0.087µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [39.062µs; 39.401µs] or [-0.433%; +0.433%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 845c86b 1739210166 SVLS-6036-respect-timeouts
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.274µs 4.289µs ± 0.003µs 4.289µs ± 0.001µs 4.290µs 4.294µs 4.297µs 4.316µs 0.62% 1.769 17.364 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 231719971.034op/s 233134717.282op/s ± 187219.024op/s 233148267.117op/s ± 73417.042op/s 233221095.473op/s 233368236.730op/s 233527100.726op/s 233990083.554op/s 0.36% -1.730 17.110 0.08% 13238.384op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 89.592µs 91.060µs ± 0.601µs 91.065µs ± 0.336µs 91.384µs 91.898µs 92.216µs 95.649µs 5.03% 2.134 15.545 0.66% 0.042µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10454925.158op/s 10982222.166op/s ± 71516.261op/s 10981131.678op/s ± 40460.846op/s 11030897.823op/s 11083757.428op/s 11127511.382op/s 11161715.397op/s 1.64% -1.891 13.376 0.65% 5056.963op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 83.193µs 83.612µs ± 0.359µs 83.598µs ± 0.125µs 83.707µs 83.913µs 84.096µs 87.981µs 5.24% 9.054 107.831 0.43% 0.025µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11366060.262op/s 11960246.990op/s ± 49492.669op/s 11961974.081op/s ± 17881.791op/s 11980886.592op/s 12003247.795op/s 12015026.274op/s 12020197.538op/s 0.49% -8.699 102.139 0.41% 3499.660op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.271µs 4.288µs ± 0.004µs 4.288µs ± 0.001µs 4.289µs 4.292µs 4.295µs 4.339µs 1.19% 7.109 81.392 0.10% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 230478823.955op/s 233211042.150op/s ± 242386.530op/s 233222931.487op/s ± 75574.353op/s 233291963.114op/s 233434995.459op/s 233541198.085op/s 234116904.114op/s 0.38% -7.006 80.015 0.10% 17139.316op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 80.441µs 81.030µs ± 0.168µs 81.030µs ± 0.066µs 81.088µs 81.404µs 81.507µs 81.543µs 0.63% 0.358 2.621 0.21% 0.012µs 1 200
credit_card/is_card_number/378282246310005 throughput 12263455.013op/s 12341186.412op/s ± 25596.351op/s 12341134.639op/s ± 10120.602op/s 12352000.436op/s 12375810.561op/s 12406874.302op/s 12431474.006op/s 0.73% -0.330 2.617 0.21% 1809.935op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.565µs 58.684µs ± 0.098µs 58.674µs ± 0.022µs 58.697µs 58.743µs 58.827µs 59.729µs 1.80% 8.126 77.232 0.17% 0.007µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16742333.529op/s 17040375.634op/s ± 28185.591op/s 17043381.885op/s ± 6282.006op/s 17049048.917op/s 17061232.445op/s 17066654.692op/s 17074962.982op/s 0.19% -8.060 76.281 0.16% 1993.022op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.416µs 6.444µs ± 0.004µs 6.443µs ± 0.002µs 6.446µs 6.449µs 6.453µs 6.458µs 0.22% -1.388 13.827 0.06% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 154856244.420op/s 155191854.776op/s ± 91503.160op/s 155200488.254op/s ± 46452.402op/s 155241276.675op/s 155277544.055op/s 155388443.767op/s 155858675.941op/s 0.42% 1.412 13.998 0.06% 6470.251op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.273µs 4.288µs ± 0.003µs 4.288µs ± 0.002µs 4.290µs 4.294µs 4.295µs 4.297µs 0.19% -0.542 3.134 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 232742302.894op/s 233189630.013op/s ± 164513.768op/s 233184725.131op/s ± 90081.512op/s 233271068.556op/s 233476887.940op/s 233554185.671op/s 234041208.507op/s 0.37% 0.553 3.173 0.07% 11632.880op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 69.059µs 69.959µs ± 0.357µs 69.955µs ± 0.226µs 70.170µs 70.526µs 70.753µs 71.426µs 2.10% 0.317 0.747 0.51% 0.025µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14000545.140op/s 14294492.926op/s ± 72860.782op/s 14294971.744op/s ± 46284.479op/s 14343089.189op/s 14411173.051op/s 14443659.876op/s 14480301.474op/s 1.30% -0.277 0.666 0.51% 5152.035op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 64.279µs 65.269µs ± 0.406µs 65.242µs ± 0.242µs 65.524µs 65.919µs 66.313µs 67.110µs 2.86% 0.716 2.003 0.62% 0.029µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 14900933.466op/s 15321795.460op/s ± 94840.141op/s 15327613.051op/s ± 56852.452op/s 15381600.149op/s 15464481.339op/s 15512041.710op/s 15557133.269op/s 1.50% -0.653 1.795 0.62% 6706.211op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.274µs 4.288µs ± 0.003µs 4.288µs ± 0.002µs 4.289µs 4.292µs 4.293µs 4.296µs 0.20% -0.776 3.425 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 232755561.466op/s 233215676.775op/s ± 147031.514op/s 233210948.456op/s ± 83678.007op/s 233297433.729op/s 233463354.349op/s 233582864.961op/s 233982386.231op/s 0.33% 0.785 3.460 0.06% 10396.698op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 61.667µs 61.940µs ± 0.114µs 61.914µs ± 0.059µs 62.001µs 62.184µs 62.241µs 62.314µs 0.65% 0.845 0.650 0.18% 0.008µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 16047678.644op/s 16144671.233op/s ± 29609.232op/s 16151412.518op/s ± 15481.724op/s 16164825.752op/s 16181318.344op/s 16202841.867op/s 16216199.984op/s 0.40% -0.835 0.633 0.18% 2093.689op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.541µs 58.670µs ± 0.038µs 58.672µs ± 0.023µs 58.692µs 58.732µs 58.749µs 58.752µs 0.14% -0.438 0.609 0.06% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 17020739.522op/s 17044616.872op/s ± 11081.019op/s 17043771.746op/s ± 6755.043op/s 17051176.514op/s 17063144.383op/s 17075018.295op/s 17081959.742op/s 0.22% 0.443 0.616 0.06% 783.546op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.410µs 6.443µs ± 0.005µs 6.443µs ± 0.002µs 6.445µs 6.449µs 6.451µs 6.454µs 0.18% -3.461 17.604 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 154935916.091op/s 155217828.659op/s ± 129671.747op/s 155209094.037op/s ± 40103.216op/s 155249788.340op/s 155314888.130op/s 155932273.875op/s 155999642.798op/s 0.51% 3.480 17.725 0.08% 9169.177op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.289µs; 4.290µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [233108770.525op/s; 233160664.038op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [90.977µs; 91.143µs] or [-0.091%; +0.091%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10972310.700op/s; 10992133.632op/s] or [-0.090%; +0.090%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [83.562µs; 83.662µs] or [-0.060%; +0.060%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11953387.783op/s; 11967106.198op/s] or [-0.057%; +0.057%] None None None
credit_card/is_card_number/37828224631 execution_time [4.287µs; 4.289µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/37828224631 throughput [233177449.708op/s; 233244634.592op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/378282246310005 execution_time [81.007µs; 81.053µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/378282246310005 throughput [12337639.004op/s; 12344733.820op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [58.671µs; 58.698µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [17036469.383op/s; 17044281.886op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.443µs; 6.444µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 throughput [155179173.318op/s; 155204536.234op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.288µs; 4.289µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [233166829.987op/s; 233212430.039op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [69.909µs; 70.008µs] or [-0.071%; +0.071%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [14284395.122op/s; 14304590.729op/s] or [-0.071%; +0.071%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [65.213µs; 65.325µs] or [-0.086%; +0.086%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15308651.529op/s; 15334939.392op/s] or [-0.086%; +0.086%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.288µs; 4.288µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [233195299.621op/s; 233236053.929op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [61.924µs; 61.956µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [16140567.678op/s; 16148774.787op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [58.664µs; 58.675µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [17043081.149op/s; 17046152.594op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.442µs; 6.443µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [155199857.402op/s; 155235799.916op/s] or [-0.012%; +0.012%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 845c86b 1739210166 SVLS-6036-respect-timeouts
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.366ms 6.382ms ± 0.009ms 6.381ms ± 0.004ms 6.385ms 6.392ms 6.418ms 6.455ms 1.16% 3.572 22.336 0.15% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.381ms; 6.383ms] or [-0.020%; +0.020%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 845c86b 1739210166 SVLS-6036-respect-timeouts
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 57.467ms 57.658ms ± 0.160ms 57.631ms ± 0.050ms 57.681ms 57.891ms 58.410ms 58.772ms 1.98% 4.062 22.185 0.28% 0.011ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [57.636ms; 57.680ms] or [-0.038%; +0.038%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 845c86b 1739210166 SVLS-6036-respect-timeouts
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 138.567µs 139.213µs ± 0.404µs 139.133µs ± 0.138µs 139.284µs 139.868µs 140.456µs 142.634µs 2.52% 3.736 25.394 0.29% 0.029µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [139.157µs; 139.269µs] or [-0.040%; +0.040%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 845c86b 1739210166 SVLS-6036-respect-timeouts
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.407µs 3.378µs ± 1.509µs 3.172µs ± 0.026µs 3.199µs 3.814µs 14.658µs 15.681µs 394.40% 7.427 55.936 44.57% 0.107µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.169µs; 3.587µs] or [-6.192%; +6.192%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 845c86b 1739210166 SVLS-6036-respect-timeouts
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 261.441ns 274.309ns ± 15.256ns 268.215ns ± 4.118ns 275.680ns 303.891ns 323.869ns 328.559ns 22.50% 1.692 2.041 5.55% 1.079ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [272.195ns; 276.423ns] or [-0.771%; +0.771%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 845c86b 1739210166 SVLS-6036-respect-timeouts
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.391µs 5.453µs ± 0.026µs 5.452µs ± 0.024µs 5.476µs 5.489µs 5.492µs 5.495µs 0.79% -0.126 -1.275 0.48% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.450µs; 5.457µs] or [-0.066%; +0.066%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 845c86b 1739210166 SVLS-6036-respect-timeouts
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 182.712µs 186.675µs ± 1.932µs 186.531µs ± 1.246µs 187.798µs 189.862µs 191.600µs 194.524µs 4.28% 0.449 0.796 1.03% 0.137µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5140761.768op/s 5357462.442op/s ± 55208.728op/s 5361040.794op/s ± 35572.821op/s 5394302.759op/s 5451130.891op/s 5460474.307op/s 5473080.789op/s 2.09% -0.371 0.613 1.03% 3903.847op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 21.017µs 21.269µs ± 0.131µs 21.246µs ± 0.078µs 21.336µs 21.518µs 21.629µs 21.773µs 2.48% 0.948 1.164 0.62% 0.009µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 45928021.605op/s 47018654.266op/s ± 288633.869op/s 47067490.706op/s ± 172958.715op/s 47219989.825op/s 47400185.594op/s 47512590.704op/s 47580589.106op/s 1.09% -0.906 1.044 0.61% 20409.497op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 14.187µs 14.265µs ± 0.043µs 14.261µs ± 0.028µs 14.290µs 14.343µs 14.376µs 14.412µs 1.06% 0.519 0.205 0.30% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 69384312.940op/s 70104442.235op/s ± 211673.996op/s 70118931.915op/s ± 137773.040op/s 70255604.780op/s 70412293.461op/s 70470955.081op/s 70488923.783op/s 0.53% -0.502 0.171 0.30% 14967.612op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [186.408µs; 186.943µs] or [-0.143%; +0.143%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5349811.043op/s; 5365113.841op/s] or [-0.143%; +0.143%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [21.251µs; 21.287µs] or [-0.086%; +0.086%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [46978652.388op/s; 47058656.144op/s] or [-0.085%; +0.085%] None None None
normalization/normalize_name/normalize_name/good execution_time [14.259µs; 14.271µs] or [-0.042%; +0.042%] None None None
normalization/normalize_name/normalize_name/good throughput [70075106.255op/s; 70133778.215op/s] or [-0.042%; +0.042%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 845c86b 1739210166 SVLS-6036-respect-timeouts
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.477µs 27.821µs ± 13.484µs 19.014µs ± 0.257µs 36.318µs 45.361µs 55.818µs 142.935µs 651.75% 3.870 27.397 48.34% 0.953µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [25.953µs; 29.690µs] or [-6.717%; +6.717%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 845c86b 1739210166 SVLS-6036-respect-timeouts
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 68.906µs 69.193µs ± 0.245µs 69.163µs ± 0.050µs 69.227µs 69.364µs 69.524µs 72.341µs 4.60% 10.681 134.089 0.35% 0.017µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [69.159µs; 69.227µs] or [-0.049%; +0.049%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 845c86b 1739210166 SVLS-6036-respect-timeouts
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 700.771µs 702.031µs ± 0.700µs 701.971µs ± 0.420µs 702.414µs 703.062µs 703.453µs 707.366µs 0.77% 2.309 15.398 0.10% 0.049µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1413694.546op/s 1424439.265op/s ± 1416.237op/s 1424560.664op/s ± 852.373op/s 1425340.800op/s 1426412.139op/s 1426780.816op/s 1427000.630op/s 0.17% -2.274 15.059 0.10% 100.143op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 472.646µs 473.701µs ± 0.542µs 473.646µs ± 0.221µs 473.889µs 474.241µs 474.589µs 478.218µs 0.97% 5.060 38.444 0.11% 0.038µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2091098.140op/s 2111037.890op/s ± 2399.920op/s 2111282.712op/s ± 985.362op/s 2112152.931op/s 2113373.983op/s 2113952.461op/s 2115749.539op/s 0.21% -5.009 37.919 0.11% 169.700op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 190.167µs 191.138µs ± 0.663µs 191.052µs ± 0.210µs 191.265µs 191.852µs 192.784µs 196.579µs 2.89% 5.575 41.989 0.35% 0.047µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5087012.037op/s 5231884.684op/s ± 17821.191op/s 5234170.760op/s ± 5746.973op/s 5239584.538op/s 5247433.765op/s 5253403.587op/s 5258526.701op/s 0.47% -5.442 40.527 0.34% 1260.148op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 45.966µs 46.256µs ± 0.094µs 46.253µs ± 0.066µs 46.320µs 46.386µs 46.448µs 46.771µs 1.12% 0.548 3.720 0.20% 0.007µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21380673.557op/s 21619136.995op/s ± 43846.238op/s 21620006.916op/s ± 30607.493op/s 21643664.997op/s 21693797.969op/s 21706192.781op/s 21755130.381op/s 0.62% -0.515 3.568 0.20% 3100.397op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.980µs 49.174µs ± 0.191µs 49.158µs ± 0.047µs 49.205µs 49.274µs 49.378µs 51.176µs 4.11% 8.167 76.850 0.39% 0.014µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19540343.735op/s 20336272.553op/s ± 76612.235op/s 20342766.259op/s ± 19298.066op/s 20361316.239op/s 20392494.339op/s 20411117.692op/s 20416530.068op/s 0.36% -8.025 74.894 0.38% 5417.303op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [701.934µs; 702.128µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1424242.988op/s; 1424635.542op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [473.626µs; 473.776µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2110705.284op/s; 2111370.496op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [191.046µs; 191.230µs] or [-0.048%; +0.048%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5229414.838op/s; 5234354.529op/s] or [-0.047%; +0.047%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [46.242µs; 46.269µs] or [-0.028%; +0.028%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21613060.328op/s; 21625213.662op/s] or [-0.028%; +0.028%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.147µs; 49.200µs] or [-0.054%; +0.054%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20325654.834op/s; 20346890.272op/s] or [-0.052%; +0.052%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 845c86b 1739210166 SVLS-6036-respect-timeouts
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.705µs 2.760µs ± 0.019µs 2.761µs ± 0.007µs 2.767µs 2.804µs 2.807µs 2.810µs 1.78% 0.135 1.769 0.68% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.757µs; 2.763µs] or [-0.095%; +0.095%] None None None

Baseline

Omitted due to size.

morrisonlevi
morrisonlevi reviewed Feb 4, 2025
View reviewed changes
dogstatsd/src/flusher.rs Outdated Show resolved Hide resolved
dogstatsd/src/datadog.rs Outdated Show resolved Hide resolved
danielsn
danielsn requested changes Feb 4, 2025
View reviewed changes
dogstatsd/src/datadog.rs Outdated Show resolved Hide resolved
dogstatsd/src/datadog.rs Outdated Show resolved Hide resolved
astuyve
astuyve reviewed Feb 7, 2025
View reviewed changes
dogstatsd/src/flusher.rs Outdated Show resolved Hide resolved
@alexgallotta alexgallotta requested a review from a team as a code owner February 10, 2025 17:54
@alexgallotta alexgallotta requested a review from astuyve February 10, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanista duncanista Awaiting requested review from duncanista

@danielsn danielsn Awaiting requested review from danielsn

@morrisonlevi morrisonlevi Awaiting requested review from morrisonlevi

@astuyve astuyve Awaiting requested review from astuyve

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexgallotta @codecov-commenter @morrisonlevi @astuyve @danielsn