Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for telemetry client to finish so the metrics are flushed. #862

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Wait for telemetry client to finish so the metrics are flushed. #862

wants to merge 1 commit into from

Conversation

hoolioh
Copy link
Contributor

@hoolioh hoolioh commented Feb 6, 2025

What does this PR do?

Waits for the task completion so the enqueued metrics are properly flushed.

@hoolioh hoolioh marked this pull request as ready for review February 6, 2025 14:24
@hoolioh hoolioh requested a review from a team as a code owner February 6, 2025 14:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.89%. Comparing base (faad98b) to head (8404276).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
- Coverage   71.89%   71.89%   -0.01%     
==========================================
  Files         322      322              
  Lines       48026    48043      +17     
==========================================
+ Hits        34530    34539       +9     
- Misses      13496    13504       +8
Components Coverage Δ
crashtracker 43.23% <ø> (-0.09%) ⬇️
crashtracker-ffi 6.30% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.02% <100.00%> (-0.02%) ⬇️
data-pipeline-ffi 89.93% <ø> (ø)
ddcommon 80.08% <ø> (ø)
ddcommon-ffi 61.05% <ø> (ø)
ddtelemetry 61.74% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 90.01% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.68% <ø> (ø)
profiling 80.04% <ø> (ø)
profiling-ffi 70.68% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.89% <ø> (ø)
sidecar-ffi 3.84% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 93.60% <ø> (ø)
trace-mini-agent 72.48% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.96% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.87% <ø> (ø)

ganeshnj
ganeshnj reviewed Feb 6, 2025
View reviewed changes
data-pipeline/src/telemetry/mod.rs
/// Shutdowns the telemetry client.
pub async fn shutdown(&self) {
pub async fn shutdown(self) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓
what would happen in case of start-shutdown-start?

we should add a test here for above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case the compiler will complain because the TelemetryClient is consumed by the shutdown method so there is no way to start again the client.

@hoolioh hoolioh force-pushed the julio/fix-flush-metrics-on-shutdown branch from 8404276 to 285d2f4 Compare February 7, 2025 10:03
@hoolioh hoolioh enabled auto-merge (squash) February 7, 2025 10:03
@pr-commenter
Copy link

pr-commenter bot commented Feb 7, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-02-07 10:14:21

Comparing candidate commit 285d2f4 in PR branch julio/fix-flush-metrics-on-shutdown with baseline commit f439466 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 285d2f4 1738922602 julio/fix-flush-metrics-on-shutdown
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.268µs 4.287µs ± 0.003µs 4.287µs ± 0.002µs 4.288µs 4.291µs 4.292µs 4.300µs 0.31% -0.797 11.930 0.06% 0.000µs 1 200
credit_card/is_card_number/ throughput 232531170.534op/s 233258943.703op/s ± 150677.974op/s 233263004.637op/s ± 84076.591op/s 233349118.226op/s 233422552.120op/s 233531145.799op/s 234288351.141op/s 0.44% 0.823 12.052 0.06% 10654.542op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 88.783µs 89.472µs ± 0.340µs 89.460µs ± 0.223µs 89.653µs 90.056µs 90.329µs 90.814µs 1.51% 0.592 0.567 0.38% 0.024µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11011534.287op/s 11176788.414op/s ± 42422.067op/s 11178179.635op/s ± 27881.433op/s 11206958.131op/s 11242176.996op/s 11248091.184op/s 11263355.247op/s 0.76% -0.567 0.505 0.38% 2999.693op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 80.474µs 81.065µs ± 0.250µs 81.047µs ± 0.155µs 81.214µs 81.462µs 81.835µs 82.143µs 1.35% 0.661 1.806 0.31% 0.018µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12173948.046op/s 12335897.139op/s ± 37982.870op/s 12338558.319op/s ± 23634.393op/s 12360514.368op/s 12395679.799op/s 12412227.818op/s 12426332.642op/s 0.71% -0.631 1.718 0.31% 2685.795op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.273µs 4.286µs ± 0.002µs 4.286µs ± 0.001µs 4.287µs 4.289µs 4.292µs 4.297µs 0.26% -0.707 6.979 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 232695328.736op/s 233303878.072op/s ± 131033.861op/s 233300963.741op/s ± 57241.804op/s 233358158.882op/s 233535979.866op/s 233661548.600op/s 234043831.175op/s 0.32% 0.721 7.008 0.06% 9265.493op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 77.290µs 77.639µs ± 0.228µs 77.583µs ± 0.123µs 77.767µs 78.062µs 78.378µs 78.468µs 1.14% 1.149 1.520 0.29% 0.016µs 1 200
credit_card/is_card_number/378282246310005 throughput 12744097.630op/s 12880212.721op/s ± 37626.535op/s 12889354.699op/s ± 20400.558op/s 12907039.501op/s 12929091.944op/s 12937013.559op/s 12938310.337op/s 0.38% -1.129 1.456 0.29% 2660.598op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 59.211µs 59.548µs ± 0.123µs 59.536µs ± 0.087µs 59.635µs 59.749µs 59.831µs 59.876µs 0.57% 0.077 -0.298 0.21% 0.009µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16701169.161op/s 16793275.397op/s ± 34712.669op/s 16796434.982op/s ± 24695.722op/s 16816359.377op/s 16849628.898op/s 16866493.864op/s 16888623.049op/s 0.55% -0.067 -0.297 0.21% 2454.556op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.838µs 6.851µs ± 0.010µs 6.849µs ± 0.002µs 6.852µs 6.867µs 6.896µs 6.910µs 0.89% 3.820 17.319 0.14% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 144716265.424op/s 145956763.477op/s ± 203010.249op/s 146003628.193op/s ± 42149.857op/s 146038828.073op/s 146122364.343op/s 146202900.569op/s 146232216.760op/s 0.16% -3.801 17.159 0.14% 14354.992op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.271µs 4.286µs ± 0.002µs 4.286µs ± 0.001µs 4.287µs 4.289µs 4.291µs 4.304µs 0.43% 1.237 23.495 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 232329055.984op/s 233307520.855op/s ± 127390.125op/s 233322898.448op/s ± 60983.405op/s 233372689.564op/s 233435661.966op/s 233473434.440op/s 234113366.840op/s 0.34% -1.198 23.379 0.05% 9007.842op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 68.720µs 69.192µs ± 0.171µs 69.193µs ± 0.104µs 69.293µs 69.503µs 69.623µs 69.678µs 0.70% 0.120 0.165 0.25% 0.012µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14351648.445op/s 14452535.099op/s ± 35659.517op/s 14452420.464op/s ± 21680.960op/s 14474636.097op/s 14512400.346op/s 14532214.259op/s 14551871.602op/s 0.69% -0.105 0.158 0.25% 2521.509op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 61.139µs 61.458µs ± 0.141µs 61.446µs ± 0.100µs 61.549µs 61.702µs 61.763µs 61.992µs 0.89% 0.420 0.079 0.23% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16131088.150op/s 16271402.492op/s ± 37367.052op/s 16274350.810op/s ± 26633.761op/s 16299733.918op/s 16324447.420op/s 16342454.805op/s 16356262.271op/s 0.50% -0.407 0.052 0.23% 2642.250op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.271µs 4.286µs ± 0.003µs 4.286µs ± 0.001µs 4.287µs 4.289µs 4.291µs 4.304µs 0.43% 0.464 12.546 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 232322627.049op/s 233322782.980op/s ± 151533.758op/s 233312612.762op/s ± 70669.165op/s 233391667.923op/s 233567431.648op/s 233677684.568op/s 234148831.378op/s 0.36% -0.436 12.464 0.06% 10715.055op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 59.082µs 59.370µs ± 0.134µs 59.368µs ± 0.098µs 59.464µs 59.600µs 59.691µs 59.743µs 0.63% 0.254 -0.384 0.22% 0.009µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 16738311.261op/s 16843583.586op/s ± 37965.517op/s 16844011.349op/s ± 27705.752op/s 16872479.736op/s 16901781.365op/s 16912362.789op/s 16925761.008op/s 0.49% -0.244 -0.394 0.22% 2684.567op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 59.223µs 59.530µs ± 0.134µs 59.517µs ± 0.091µs 59.619µs 59.772µs 59.801µs 59.887µs 0.62% 0.133 -0.290 0.23% 0.009µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16698138.018op/s 16798404.384op/s ± 37898.406op/s 16801954.908op/s ± 25798.265op/s 16822746.877op/s 16859247.442op/s 16877778.601op/s 16885414.871op/s 0.50% -0.122 -0.294 0.23% 2679.822op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.838µs 6.851µs ± 0.011µs 6.849µs ± 0.003µs 6.852µs 6.858µs 6.909µs 6.927µs 1.14% 4.735 25.845 0.16% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 144363067.181op/s 145973699.883op/s ± 233818.927op/s 146010447.050op/s ± 54817.561op/s 146060370.404op/s 146167911.862op/s 146219788.228op/s 146234032.946op/s 0.15% -4.709 25.614 0.16% 16533.495op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.287µs; 4.287µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [233238061.185op/s; 233279826.221op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [89.425µs; 89.520µs] or [-0.053%; +0.053%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [11170909.124op/s; 11182667.705op/s] or [-0.053%; +0.053%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [81.030µs; 81.100µs] or [-0.043%; +0.043%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12330633.079op/s; 12341161.200op/s] or [-0.043%; +0.043%] None None None
credit_card/is_card_number/37828224631 execution_time [4.286µs; 4.287µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631 throughput [233285718.039op/s; 233322038.105op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/378282246310005 execution_time [77.608µs; 77.671µs] or [-0.041%; +0.041%] None None None
credit_card/is_card_number/378282246310005 throughput [12874998.046op/s; 12885427.397op/s] or [-0.040%; +0.040%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.531µs; 59.565µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16788464.555op/s; 16798086.239op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.850µs; 6.853µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/x371413321323331 throughput [145928628.209op/s; 145984898.746op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.286µs; 4.287µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ throughput [233289865.809op/s; 233325175.901op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [69.169µs; 69.216µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [14447593.033op/s; 14457477.165op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [61.438µs; 61.477µs] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16266223.778op/s; 16276581.206op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.286µs; 4.286µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [233301781.858op/s; 233343784.101op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [59.352µs; 59.389µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [16838321.930op/s; 16848845.241op/s] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.511µs; 59.548µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16793152.030op/s; 16803656.739op/s] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.849µs; 6.852µs] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [145941294.828op/s; 146006104.937op/s] or [-0.022%; +0.022%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 285d2f4 1738922602 julio/fix-flush-metrics-on-shutdown
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 57.515ms 57.889ms ± 0.179ms 57.884ms ± 0.152ms 58.034ms 58.181ms 58.226ms 58.368ms 0.84% 0.134 -0.953 0.31% 0.013ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [57.864ms; 57.914ms] or [-0.043%; +0.043%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 285d2f4 1738922602 julio/fix-flush-metrics-on-shutdown
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 79.464µs 79.656µs ± 0.145µs 79.641µs ± 0.043µs 79.684µs 79.789µs 79.925µs 81.142µs 1.88% 6.649 60.412 0.18% 0.010µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [79.636µs; 79.676µs] or [-0.025%; +0.025%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 285d2f4 1738922602 julio/fix-flush-metrics-on-shutdown
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.511µs 5.569µs ± 0.034µs 5.572µs ± 0.027µs 5.591µs 5.632µs 5.639µs 5.644µs 1.28% 0.390 -0.834 0.62% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.564µs; 5.574µs] or [-0.086%; +0.086%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 285d2f4 1738922602 julio/fix-flush-metrics-on-shutdown
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.701µs 2.755µs ± 0.015µs 2.755µs ± 0.007µs 2.763µs 2.781µs 2.795µs 2.802µs 1.67% -0.313 1.732 0.56% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.753µs; 2.757µs] or [-0.077%; +0.077%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 285d2f4 1738922602 julio/fix-flush-metrics-on-shutdown
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 274.877ns 286.682ns ± 14.781ns 280.853ns ± 3.532ns 287.125ns 317.935ns 333.828ns 335.435ns 19.43% 1.829 2.334 5.14% 1.045ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [284.633ns; 288.730ns] or [-0.715%; +0.715%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 285d2f4 1738922602 julio/fix-flush-metrics-on-shutdown
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 487.220µs 488.221µs ± 0.467µs 488.194µs ± 0.181µs 488.374µs 488.929µs 489.312µs 492.379µs 0.86% 3.632 30.181 0.10% 0.033µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 2030956.745op/s 2048256.184op/s ± 1952.638op/s 2048365.203op/s ± 761.072op/s 2049159.334op/s 2050504.285op/s 2052046.487op/s 2052462.071op/s 0.20% -3.578 29.577 0.10% 138.072op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 478.752µs 479.631µs ± 0.552µs 479.589µs ± 0.231µs 479.820µs 480.187µs 480.575µs 484.338µs 0.99% 4.878 37.142 0.11% 0.039µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2064672.049op/s 2084938.392op/s ± 2388.127op/s 2085119.060op/s ± 1004.983op/s 2086118.542op/s 2087524.072op/s 2088564.953op/s 2088763.661op/s 0.17% -4.825 36.591 0.11% 168.866op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 164.547µs 167.467µs ± 1.064µs 167.457µs ± 0.787µs 168.303µs 169.040µs 169.397µs 170.650µs 1.91% -0.130 -0.222 0.63% 0.075µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5859932.087op/s 5971571.519op/s ± 37991.294op/s 5971683.967op/s ± 28131.572op/s 5995213.970op/s 6033904.758op/s 6056316.664op/s 6077297.858op/s 1.77% 0.163 -0.214 0.63% 2686.390op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 45.581µs 45.993µs ± 0.218µs 46.021µs ± 0.190µs 46.192µs 46.294µs 46.365µs 46.405µs 0.83% -0.101 -1.229 0.47% 0.015µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21549561.038op/s 21743151.936op/s ± 103282.165op/s 21729302.898op/s ± 89177.006op/s 21843065.604op/s 21906421.813op/s 21931623.241op/s 21938978.984op/s 0.96% 0.112 -1.227 0.47% 7303.152op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 43.874µs 44.383µs ± 0.195µs 44.377µs ± 0.121µs 44.498µs 44.705µs 44.880µs 44.969µs 1.34% 0.324 0.240 0.44% 0.014µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 22237369.416op/s 22531740.122op/s ± 99055.230op/s 22534444.036op/s ± 61364.960op/s 22595696.614op/s 22680011.801op/s 22728875.765op/s 22792739.918op/s 1.15% -0.296 0.210 0.44% 7004.262op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [488.156µs; 488.285µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [2047985.567op/s; 2048526.801op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [479.555µs; 479.708µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2084607.421op/s; 2085269.364op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [167.319µs; 167.614µs] or [-0.088%; +0.088%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5966306.291op/s; 5976836.747op/s] or [-0.088%; +0.088%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [45.962µs; 46.023µs] or [-0.066%; +0.066%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21728838.021op/s; 21757465.850op/s] or [-0.066%; +0.066%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [44.356µs; 44.410µs] or [-0.061%; +0.061%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22518012.020op/s; 22545468.224op/s] or [-0.061%; +0.061%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 285d2f4 1738922602 julio/fix-flush-metrics-on-shutdown
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 251.397µs 252.172µs ± 0.535µs 252.043µs ± 0.153µs 252.201µs 253.487µs 253.779µs 254.841µs 1.11% 2.237 5.329 0.21% 0.038µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3924011.998op/s 3965563.395op/s ± 8369.161op/s 3967578.929op/s ± 2403.072op/s 3969791.869op/s 3973747.092op/s 3975442.672op/s 3977766.770op/s 0.26% -2.223 5.249 0.21% 591.789op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 22.574µs 22.634µs ± 0.036µs 22.630µs ± 0.025µs 22.656µs 22.688µs 22.721µs 22.885µs 1.13% 2.091 10.864 0.16% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 43697048.748op/s 44181507.165op/s ± 70042.415op/s 44189509.646op/s ± 48482.138op/s 44234021.858op/s 44261895.678op/s 44279546.593op/s 44297986.676op/s 0.25% -2.051 10.516 0.16% 4952.747op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 13.378µs 13.441µs ± 0.025µs 13.443µs ± 0.019µs 13.456µs 13.486µs 13.513µs 13.546µs 0.76% 0.774 1.169 0.19% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 73821622.353op/s 74400038.392op/s ± 140077.006op/s 74385917.683op/s ± 105706.197op/s 74526578.781op/s 74570500.561op/s 74601222.751op/s 74751983.597op/s 0.49% -0.759 1.123 0.19% 9904.940op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [252.098µs; 252.246µs] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3964403.510op/s; 3966723.280op/s] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [22.629µs; 22.639µs] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [44171799.959op/s; 44191214.370op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_name/normalize_name/good execution_time [13.437µs; 13.444µs] or [-0.026%; +0.026%] None None None
normalization/normalize_name/normalize_name/good throughput [74380625.066op/s; 74419451.718op/s] or [-0.026%; +0.026%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 285d2f4 1738922602 julio/fix-flush-metrics-on-shutdown
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.250ms 6.264ms ± 0.006ms 6.263ms ± 0.004ms 6.266ms 6.274ms 6.284ms 6.300ms 0.60% 1.409 5.134 0.10% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.263ms; 6.264ms] or [-0.014%; +0.014%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 285d2f4 1738922602 julio/fix-flush-metrics-on-shutdown
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.895µs 28.627µs ± 13.454µs 19.411µs ± 0.482µs 37.227µs 46.564µs 48.887µs 139.883µs 620.63% 3.530 24.092 46.88% 0.951µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [26.762µs; 30.491µs] or [-6.513%; +6.513%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 285d2f4 1738922602 julio/fix-flush-metrics-on-shutdown
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.432µs 3.379µs ± 1.481µs 3.182µs ± 0.025µs 3.206µs 3.802µs 14.518µs 15.529µs 387.97% 7.435 56.035 43.72% 0.105µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.174µs; 3.584µs] or [-6.075%; +6.075%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 285d2f4 1738922602 julio/fix-flush-metrics-on-shutdown
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 140.601µs 141.497µs ± 0.348µs 141.465µs ± 0.146µs 141.609µs 142.008µs 142.510µs 144.538µs 2.17% 3.541 28.547 0.25% 0.025µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [141.449µs; 141.545µs] or [-0.034%; +0.034%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 285d2f4 1738922602 julio/fix-flush-metrics-on-shutdown
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 39.560µs 40.286µs ± 1.346µs 39.662µs ± 0.032µs 39.727µs 43.195µs 43.297µs 43.482µs 9.63% 1.705 0.922 3.33% 0.095µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [40.099µs; 40.472µs] or [-0.463%; +0.463%] None None None

Baseline

Omitted due to size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganeshnj ganeshnj ganeshnj left review comments

@bantonsson bantonsson bantonsson approved these changes

@ekump ekump ekump approved these changes

Assignees
No one assigned
Labels
data-pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hoolioh @codecov-commenter @bantonsson @ekump @ganeshnj