Use send_with_retry in the trace exporter #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VianneyRuhlmann
force-pushed
the
vianney/data-pipeline/use-send-with-retry
branch
2 times, most recently
from
f71e4f1 to
d085821
Compare
VianneyRuhlmann
force-pushed
the
vianney/data-pipeline/use-send-with-retry
branch
from
d085821 to
e8d1c90
Compare
BenchmarksComparisonBenchmark execution time: 2025-02-18 18:05:20 Comparing candidate commit 3b66ffe in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
==========================================
+ Coverage 71.62% 71.65% +0.02%
==========================================
Files 328 328
Lines 48262 48339 +77
==========================================
+ Hits 34567 34635 +68
- Misses 13695 13704 +9
|
ganeshnj
reviewed
Feb 13, 2025
| let endpoint = Endpoint { | ||
| url: self.output_format.add_path(&self.endpoint.url), | ||
| ..self.endpoint.clone() | ||
| }; | ||
| let send_data = SendData::new(size, tracer_payload, header_tags, &endpoint); | ||
| let mut headers: HashMap<&str, String> = header_tags.into(); | ||
| headers.insert(DATADOG_SEND_REAL_HTTP_STATUS_STR, "1".to_string()); |
There was a problem hiding this comment.
For this header any non false value enables it. It can be changed to true but "1" is the value used in send data.
| let send_data_result = send_data.send().await; | ||
| // Send traces to the agent | ||
| let result = | ||
| send_with_retry(&endpoint, payload, &headers, &strategy, None).await; |
There was a problem hiding this comment.
❓ are we capturing telemetry like
- max retry count
- retry attempt
- last failure reason?
There was a problem hiding this comment.
Yes they are captured in the SendPayloadTelemetry which is sent on line 658
VianneyRuhlmann
changed the title
hoolioh
approved these changes
Feb 18, 2025
Comment on lines
660
to
661
| payload_len.try_into().unwrap_or(0), | ||
| chunks.try_into().unwrap_or(0), |
There was a problem hiding this comment.
nit: here you can use as u64, in this situation is safe to perform an unchecked casting since usize is always 32 or 64 bit depending on the architecture. Besides it'll probably be slightly faster due try_into + unwrap could result in extra branching but I haven't disassemble the code to check it.
| } | ||
|
|
||
| impl From<&SendDataResult> for SendPayloadTelemetry { | ||
| fn from(value: &SendDataResult) -> Self { |
There was a problem hiding this comment.
nit: I think there is no test for this function. Right now it's just assigning and cloning values but if something changes in SendDataResult the test might come in useful.
VianneyRuhlmann
commented
Feb 18, 2025
VianneyRuhlmann
deleted the
vianney/data-pipeline/use-send-with-retry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use
send_with_retryin trace exporter to remove ownership constraint.Motivation
Removing ownership constraint is required to remove incorrect lifetime assumption in the trace exporter.
Additional Notes
Some minor refactors were needed:
Commits although not atomic separate the changes into areas affected, so reviewing by commit can help by breaking down the changes.
How to test the change?
Describe here in detail how the change can be validated.