Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible race confition when adding, then removing remote config services #882

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

bwoebi
Copy link
Contributor

@bwoebi bwoebi commented Feb 13, 2025

This would eventually lead to a panic in debug builds due to 0u - 1.

@bwoebi bwoebi requested review from a team as code owners February 13, 2025 20:08
@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-02-14 10:30:06

Comparing candidate commit 859332c in PR branch bob/multitarget-race with baseline commit 958830a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 859332c 1739528388 bob/multitarget-race
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 32.122µs 32.975µs ± 1.181µs 32.243µs ± 0.068µs 34.645µs 34.750µs 35.561µs 35.715µs 10.77% 0.948 -0.978 3.57% 0.084µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [32.812µs; 33.139µs] or [-0.496%; +0.496%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 859332c 1739528388 bob/multitarget-race
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 53.930ms 54.118ms ± 0.145ms 54.082ms ± 0.045ms 54.145ms 54.358ms 54.694ms 54.913ms 1.54% 2.922 10.523 0.27% 0.010ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [54.098ms; 54.139ms] or [-0.037%; +0.037%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 859332c 1739528388 bob/multitarget-race
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 504.776µs 505.724µs ± 0.564µs 505.662µs ± 0.220µs 505.929µs 506.327µs 506.820µs 511.808µs 1.22% 6.376 66.118 0.11% 0.040µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1953856.424op/s 1977363.640op/s ± 2188.430op/s 1977604.291op/s ± 860.075op/s 1978331.391op/s 1979842.596op/s 1980234.329op/s 1981075.447op/s 0.18% -6.285 64.818 0.11% 154.745op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 452.629µs 453.480µs ± 0.381µs 453.437µs ± 0.228µs 453.681µs 454.057µs 454.362µs 455.844µs 0.53% 1.252 6.394 0.08% 0.027µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2193733.184op/s 2205170.299op/s ± 1852.327op/s 2205376.454op/s ± 1107.584op/s 2206377.856op/s 2207600.561op/s 2209072.410op/s 2209316.134op/s 0.18% -1.235 6.281 0.08% 130.979op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 174.763µs 176.206µs ± 0.483µs 176.182µs ± 0.334µs 176.540µs 176.954µs 177.344µs 177.616µs 0.81% -0.070 0.135 0.27% 0.034µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5630114.908op/s 5675204.629op/s ± 15557.898op/s 5675936.951op/s ± 10752.370op/s 5685794.535op/s 5699473.045op/s 5713035.069op/s 5722041.373op/s 0.81% 0.087 0.139 0.27% 1100.110op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.632µs 37.721µs ± 0.052µs 37.717µs ± 0.033µs 37.747µs 37.810µs 37.882µs 37.902µs 0.49% 0.937 1.213 0.14% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26383524.409op/s 26510390.962op/s ± 36207.208op/s 26513079.894op/s ± 22916.532op/s 26536655.570op/s 26559733.887op/s 26570390.937op/s 26572895.245op/s 0.23% -0.928 1.185 0.14% 2560.236op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.072µs 48.276µs ± 0.210µs 48.154µs ± 0.080µs 48.509µs 48.585µs 48.662µs 48.726µs 1.19% 0.389 -1.578 0.43% 0.015µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20522738.969op/s 20714698.726op/s ± 89885.919op/s 20766531.399op/s ± 34635.844op/s 20796123.603op/s 20801052.177op/s 20801623.810op/s 20802258.531op/s 0.17% -0.385 -1.583 0.43% 6355.894op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.646µs; 505.803µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1977060.345op/s; 1977666.936op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [453.427µs; 453.533µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2204913.584op/s; 2205427.014op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.139µs; 176.273µs] or [-0.038%; +0.038%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5673048.454op/s; 5677360.804op/s] or [-0.038%; +0.038%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.714µs; 37.728µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26505372.991op/s; 26515408.933op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.247µs; 48.305µs] or [-0.060%; +0.060%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20702241.402op/s; 20727156.050op/s] or [-0.060%; +0.060%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 859332c 1739528388 bob/multitarget-race
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 66.815µs 67.022µs ± 0.211µs 66.998µs ± 0.054µs 67.064µs 67.154µs 67.330µs 69.542µs 3.80% 9.071 102.194 0.31% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [66.993µs; 67.052µs] or [-0.044%; +0.044%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 859332c 1739528388 bob/multitarget-race
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 251.535ns 259.609ns ± 10.050ns 255.136ns ± 1.731ns 260.074ns 280.854ns 293.526ns 300.329ns 17.71% 1.978 3.392 3.86% 0.711ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [258.216ns; 261.002ns] or [-0.536%; +0.536%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 859332c 1739528388 bob/multitarget-race
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.743µs 209.162µs ± 0.232µs 209.133µs ± 0.080µs 209.218µs 209.378µs 209.509µs 211.248µs 1.01% 5.770 46.796 0.11% 0.016µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4733783.832op/s 4780998.652op/s ± 5263.273op/s 4781644.225op/s ± 1833.889op/s 4783331.684op/s 4785493.352op/s 4788779.226op/s 4790587.454op/s 0.19% -5.719 46.227 0.11% 372.170op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.277µs 18.356µs ± 0.080µs 18.361µs ± 0.043µs 18.387µs 18.425µs 18.458µs 19.221µs 4.69% 6.172 64.783 0.44% 0.006µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52026884.346op/s 54480225.373op/s ± 232786.767op/s 54464647.982op/s ± 128596.855op/s 54693790.037op/s 54706906.371op/s 54712579.281op/s 54714278.818op/s 0.46% -5.805 59.680 0.43% 16460.510op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.629µs 10.690µs ± 0.023µs 10.690µs ± 0.017µs 10.706µs 10.724µs 10.746µs 10.764µs 0.69% 0.034 0.111 0.22% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 92902200.424op/s 93543595.534op/s ± 202190.742op/s 93544460.785op/s ± 148726.531op/s 93696006.552op/s 93909285.867op/s 93960529.506op/s 94084815.290op/s 0.58% -0.020 0.105 0.22% 14297.044op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.129µs; 209.194µs] or [-0.015%; +0.015%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4780269.213op/s; 4781728.091op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.344µs; 18.367µs] or [-0.061%; +0.061%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54447963.366op/s; 54512487.380op/s] or [-0.059%; +0.059%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.687µs; 10.693µs] or [-0.030%; +0.030%] None None None
normalization/normalize_name/normalize_name/good throughput [93515573.842op/s; 93571617.226op/s] or [-0.030%; +0.030%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 859332c 1739528388 bob/multitarget-race
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.000µs 5.096µs ± 0.058µs 5.117µs ± 0.053µs 5.130µs 5.185µs 5.188µs 5.189µs 1.41% -0.044 -1.340 1.14% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.087µs; 5.104µs] or [-0.158%; +0.158%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 859332c 1739528388 bob/multitarget-race
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 149.377µs 150.290µs ± 0.399µs 150.252µs ± 0.208µs 150.461µs 150.813µs 151.306µs 153.727µs 2.31% 3.443 26.460 0.26% 0.028µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [150.234µs; 150.345µs] or [-0.037%; +0.037%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 859332c 1739528388 bob/multitarget-race
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.947ms 5.957ms ± 0.006ms 5.957ms ± 0.003ms 5.960ms 5.964ms 5.983ms 5.989ms 0.54% 2.305 9.769 0.09% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.957ms; 5.958ms] or [-0.013%; +0.013%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 859332c 1739528388 bob/multitarget-race
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.673µs 25.641µs ± 11.200µs 17.871µs ± 0.090µs 34.596µs 44.695µs 56.830µs 99.498µs 456.76% 2.156 9.087 43.57% 0.792µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.089µs; 27.194µs] or [-6.054%; +6.054%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 859332c 1739528388 bob/multitarget-race
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.380µs 2.442µs ± 0.019µs 2.441µs ± 0.011µs 2.456µs 2.471µs 2.480µs 2.509µs 2.80% -0.505 1.677 0.79% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.439µs; 2.445µs] or [-0.110%; +0.110%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 859332c 1739528388 bob/multitarget-race
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.172µs 3.168µs ± 1.472µs 2.975µs ± 0.026µs 2.999µs 3.601µs 13.741µs 16.342µs 449.25% 7.558 58.468 46.34% 0.104µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.964µs; 3.372µs] or [-6.439%; +6.439%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 859332c 1739528388 bob/multitarget-race
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.914µs 3.917µs 3.919µs 3.931µs 0.44% -0.589 22.737 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254400324.390op/s 255534176.825op/s ± 173667.507op/s 255526893.756op/s ± 64411.864op/s 255597015.912op/s 255757203.785op/s 255840486.235op/s 256830190.932op/s 0.51% 0.638 22.841 0.07% 12280.147op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 81.532µs 82.982µs ± 0.708µs 83.021µs ± 0.445µs 83.398µs 83.946µs 84.216µs 87.790µs 5.74% 1.369 9.143 0.85% 0.050µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11390864.038op/s 12051679.887op/s ± 101697.462op/s 12045156.880op/s ± 64878.852op/s 12121016.359op/s 12212913.895op/s 12246588.717op/s 12265098.032op/s 1.83% -1.149 7.472 0.84% 7191.096op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 78.425µs 79.626µs ± 0.521µs 79.666µs ± 0.256µs 79.906µs 80.181µs 80.330µs 84.480µs 6.04% 3.732 35.971 0.65% 0.037µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11837137.761op/s 12559188.316op/s ± 80382.112op/s 12552356.670op/s ± 40271.917op/s 12596180.404op/s 12683400.228op/s 12722042.252op/s 12751002.736op/s 1.58% -3.284 31.023 0.64% 5683.874op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.896µs 3.914µs ± 0.002µs 3.914µs ± 0.001µs 3.915µs 3.916µs 3.917µs 3.918µs 0.11% -3.151 22.835 0.05% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255231190.929op/s 255524277.948op/s ± 138889.795op/s 255521874.188op/s ± 61996.213op/s 255578390.847op/s 255720239.738op/s 255894708.577op/s 256678898.414op/s 0.45% 3.175 23.088 0.05% 9820.992op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 74.933µs 76.239µs ± 0.420µs 76.282µs ± 0.289µs 76.553µs 76.829µs 77.036µs 77.288µs 1.32% -0.404 0.065 0.55% 0.030µs 1 200
credit_card/is_card_number/378282246310005 throughput 12938639.482op/s 13117119.733op/s ± 72512.495op/s 13109291.620op/s ± 49504.108op/s 13162326.468op/s 13236331.360op/s 13311327.407op/s 13345257.793op/s 1.80% 0.436 0.108 0.55% 5127.408op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.367µs 51.430µs ± 0.029µs 51.429µs ± 0.016µs 51.445µs 51.469µs 51.528µs 51.602µs 0.34% 1.424 6.652 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19379084.204op/s 19443760.068op/s ± 10777.443op/s 19444428.795op/s ± 5903.132op/s 19450009.101op/s 19460033.081op/s 19466340.828op/s 19467592.299op/s 0.12% -1.413 6.586 0.06% 762.080op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.028µs 6.038µs ± 0.003µs 6.037µs ± 0.001µs 6.039µs 6.044µs 6.049µs 6.051µs 0.23% 0.892 3.028 0.05% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165262088.518op/s 165622974.942op/s ± 88109.281op/s 165635824.400op/s ± 38396.023op/s 165668986.766op/s 165738855.885op/s 165844097.460op/s 165879149.481op/s 0.15% -0.885 3.016 0.05% 6230.267op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.895µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.919µs 3.922µs 3.925µs 0.29% -0.908 13.566 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254772498.923op/s 255495465.832op/s ± 177764.085op/s 255508591.805op/s ± 66940.084op/s 255572672.892op/s 255699838.002op/s 255901052.607op/s 256752923.327op/s 0.49% 0.939 13.740 0.07% 12569.819op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.955µs 66.236µs ± 0.152µs 66.222µs ± 0.091µs 66.317µs 66.458µs 66.882µs 67.155µs 1.41% 1.912 8.321 0.23% 0.011µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14891004.748op/s 15097542.968op/s ± 34492.355op/s 15100807.894op/s ± 20868.273op/s 15119500.377op/s 15143917.517op/s 15153628.677op/s 15161866.480op/s 0.40% -1.866 8.028 0.23% 2438.978op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 59.465µs 59.681µs ± 0.096µs 59.683µs ± 0.069µs 59.752µs 59.841µs 59.873µs 59.909µs 0.38% -0.071 -0.593 0.16% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16691876.699op/s 16755889.329op/s ± 26917.254op/s 16755328.619op/s ± 19485.508op/s 16774401.844op/s 16801959.702op/s 16813063.095op/s 16816564.316op/s 0.37% 0.078 -0.592 0.16% 1903.337op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.914µs ± 0.002µs 3.914µs ± 0.001µs 3.915µs 3.918µs 3.920µs 3.922µs 0.20% -1.857 16.441 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254985057.676op/s 255501901.834op/s ± 163110.401op/s 255504777.946op/s ± 73318.363op/s 255576596.308op/s 255677243.139op/s 255924862.769op/s 256744595.099op/s 0.49% 1.886 16.665 0.06% 11533.647op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 56.299µs 56.774µs ± 0.185µs 56.754µs ± 0.140µs 56.915µs 57.088µs 57.149µs 57.224µs 0.83% -0.001 -0.444 0.32% 0.013µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17475247.702op/s 17613826.500op/s ± 57346.310op/s 17619991.659op/s ± 43534.341op/s 17652815.461op/s 17708181.949op/s 17740784.918op/s 17762288.703op/s 0.81% 0.016 -0.441 0.32% 4054.996op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.352µs 51.446µs ± 0.031µs 51.439µs ± 0.017µs 51.461µs 51.503µs 51.541µs 51.542µs 0.20% 0.667 0.842 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19401625.996op/s 19437963.219op/s ± 11608.753op/s 19440581.806op/s ± 6311.522op/s 19445673.165op/s 19452550.464op/s 19462461.857op/s 19473288.490op/s 0.17% -0.663 0.838 0.06% 820.863op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.029µs 6.037µs ± 0.003µs 6.037µs ± 0.001µs 6.039µs 6.042µs 6.044µs 6.049µs 0.20% 0.787 3.129 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165310165.568op/s 165631554.164op/s ± 71291.178op/s 165644716.076op/s ± 36180.917op/s 165671856.494op/s 165718589.489op/s 165822472.545op/s 165860519.811op/s 0.13% -0.781 3.117 0.04% 5041.048op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.913µs; 3.914µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255510108.179op/s; 255558245.471op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [82.884µs; 83.080µs] or [-0.118%; +0.118%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12037585.597op/s; 12065774.177op/s] or [-0.117%; +0.117%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [79.554µs; 79.699µs] or [-0.091%; +0.091%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12548048.128op/s; 12570328.503op/s] or [-0.089%; +0.089%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631 throughput [255505029.159op/s; 255543526.738op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/378282246310005 execution_time [76.180µs; 76.297µs] or [-0.076%; +0.076%] None None None
credit_card/is_card_number/378282246310005 throughput [13107070.198op/s; 13127169.267op/s] or [-0.077%; +0.077%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [51.426µs; 51.434µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19442266.418op/s; 19445253.718op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.037µs; 6.038µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/x371413321323331 throughput [165610763.843op/s; 165635186.041op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.914µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255470829.439op/s; 255520102.224op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [66.215µs; 66.257µs] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15092762.660op/s; 15102323.277op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [59.667µs; 59.694µs] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [16752158.856op/s; 16759619.801op/s] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.914µs; 3.914µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255479296.301op/s; 255524507.366op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [56.749µs; 56.800µs] or [-0.045%; +0.045%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [17605878.853op/s; 17621774.147op/s] or [-0.045%; +0.045%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [51.441µs; 51.450µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19436354.357op/s; 19439572.080op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.037µs; 6.038µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165621673.892op/s; 165641434.435op/s] or [-0.006%; +0.006%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 31.57895% with 26 lines in your changes missing coverage. Please review.

Project coverage is 71.65%. Comparing base (958830a) to head (859332c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
- Coverage   71.66%   71.65%   -0.02%     
==========================================
  Files         324      324              
  Lines       48235    48248      +13     
==========================================
+ Hits        34568    34571       +3     
- Misses      13667    13677      +10     
Components Coverage Δ
crashtracker 42.60% <ø> (-0.12%) ⬇️
crashtracker-ffi 6.25% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.01% <ø> (ø)
data-pipeline-ffi 90.39% <ø> (ø)
ddcommon 80.08% <ø> (ø)
ddcommon-ffi 61.05% <ø> (ø)
ddtelemetry 61.74% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 90.01% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.68% <ø> (ø)
profiling 80.04% <ø> (ø)
profiling-ffi 70.68% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.97% <ø> (ø)
sidecar-ffi 5.14% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 92.79% <ø> (ø)
trace-mini-agent 72.48% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.96% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.22% <ø> (ø)

@bwoebi bwoebi enabled auto-merge (squash) February 14, 2025 10:19
@bwoebi bwoebi merged commit 7a481f8 into main Feb 14, 2025
31 checks passed
@bwoebi bwoebi deleted the bob/multitarget-race branch February 14, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants