Add generic Span #884
Merged
Add generic Span #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksComparisonBenchmark execution time: 2025-02-21 12:23:29 Comparing candidate commit 4be708f in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics. scenario:benching deserializing traces from msgpack to their internal representation
scenario:credit_card/is_card_number/378282246310005
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
==========================================
+ Coverage 71.77% 71.79% +0.01%
==========================================
Files 328 328
Lines 48577 48600 +23
==========================================
+ Hits 34866 34892 +26
+ Misses 13711 13708 -3
|
bantonsson
approved these changes
Feb 20, 2025
trace-utils/src/span/v04/span.rs
Outdated
| /// from a static str. | ||
| pub trait SpanValue: Eq + Hash + Borrow<str> {} | ||
| /// Implement the SpanValue trait for any type which satisfies the sub trait. | ||
| impl<T: Eq + Hash + Borrow<str>> SpanValue for T {} |
There was a problem hiding this comment.
Nice. Makes things way more readable.
ganeshnj
approved these changes
Feb 21, 2025
trace-utils/src/span/v04/span.rs
Outdated
| /// Trait representing the requirements for a type to be used as a Span "string" type. | ||
| /// Note: Borrow<str> is not required by the derived traits, but allows to access HashMap elements | ||
| /// from a static str. | ||
| pub trait SpanValue: Eq + Hash + Borrow<str> {} |
There was a problem hiding this comment.
SpanValue is too broad as name, given this is explicitly targeting the strings, I would prefer SpanString to narrow down the scope.
VianneyRuhlmann
force-pushed
the
vianney/add-generic-span
branch
from
a6e6591 to
4be708f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a span with a generic string type to be used to support BytesStrings and &str.
Motivation
Supporting slice based spans is required to support borrowed payload.
Additional Notes
The functions in
trace-utils/src/span/v04/trace_utils.rshave been modified to use a generic span to show how to use the new type.Many files have been changed for renaming but most changes are in
trace-utils/src/span/v04.`
How to test the change?
Describe here in detail how the change can be validated.