Add config options for max queue message kbyptes #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeavital
changed the title
xvandish-dd
force-pushed
the
master
branch
2 times, most recently
from
9ef9312 to
e01a342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option should behave exactly as queued.max.messages.kbytes behaves except it takes into account the queued size of all topic-partition queues at once instead of imposing a per-queue limit.
The issue with a per-queue limit, is that with dynamic partition assignment the number of partitions assigned to a single worker can change dramatically. Thus saying "2000kb" queued could be between 2000kb or ~1.5 gigabytes for a 720 partition topic depending on how many partitions are assigned in an instant.
This is particularly an issue for messages which are well compressed, because the size constraint in both instances is imposed before decompression.