Use custom labels for trace to profile correlation for native #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When uploading elf symbols, it is sometimes necessary to open a file other than the reported executalle (eg. to look for separate debug information).
Starting with Python 3.12, PyGILState_GetThisThreadState calls PyThread_tss_is_created first before calling PyThread_tss_get. On default builds of python (without `--enable-optimizations`, `--with-lto`), the calls to PyThread_tss_is_created and PyThread_tss_get are not inlined, so the value of autoTLSKey is stored in a register before being passed to both function calls. This causes the decode disassembler to not find the value in the call instruction. To work around this, we look into PyGILState_Release which as of Python 3.13, calls PyThread_tss_get directly.
* support/.gitignore * support/ebpf/tracer.ebpf.debug.amd64 * support/ebpf/tracer.ebpf.debug.arm64
This change makes systemProcess.Open return `/proc/<profiler_pid>/fd/<elf_fd>` as actual path instead of `/proc/<process_pid>/map_files/<mapping>`. The upside of this change is that the new path remains valid even after the target process has been terminated, while the old path becomes invalid.
* pass both go and gnu build ids
If a zero size is provided for the tracehandler cache, the cache will not be created.
* .github/workflows/unit-test-on-pull-request.yml * Cargo.lock * Cargo.toml * Makefile * customlabelstest/customlabels_test.go * host/host.go * interpreter/customlabels/customlabels.go * libpf/interpretertype.go * libpf/pfelf/file.go * libpf/trace.go * processmanager/ebpf/ebpf.go * processmanager/execinfomanager/manager.go * processmanager/manager.go * processmanager/manager_test.go * remotememory/remotememory.go * rust-crates/custom-labels-example/Cargo.lock * rust-crates/custom-labels-example/Cargo.toml * rust-crates/custom-labels-example/build.rs * rust-crates/custom-labels-example/src/main.rs * support/ebpf/interpreter_dispatcher.ebpf.c * support/ebpf/tracemgmt.h * support/ebpf/tracer.ebpf.debug.amd64 * support/ebpf/tracer.ebpf.debug.arm64 * support/ebpf/tracer.ebpf.debug.amd64 * support/ebpf/tracer.ebpf.release.amd64 * support/ebpf/types.h * support/ebpf/util.h * support/types.go * target/aarch64-unknown-linux-musl/release/libsymblib_capi.a * target/x86_64-unknown-linux-musl/release/libsymblib_capi.a * testutils/helpers.go * tools/coredump/coredump.go * tracer/ebpf_integration_test.go * tracer/tracer.go
* host/host.go * interpreter/customlabels/customlabels.go * processmanager/manager.go * reporter/samples/samples.go * support/ebpf/tracer.ebpf.debug.amd64 * support/ebpf/tracer.ebpf.debug.arm64 * support/ebpf/tracer.ebpf.release.amd64 * support/ebpf/tracer.ebpf.release.arm64 * support/ebpf/types.h * tracehandler/tracehandler.go * tracehandler/tracehandler_test.go * tracer/tracer.go
* interpreter/customlabels/customlabels.go
peterg17
pushed a commit
that referenced
this pull request
Jul 25, 2025
nsavoire
added a commit
that referenced
this pull request
Jul 29, 2025
nsavoire
added a commit
that referenced
this pull request
Aug 1, 2025
nsavoire
added a commit
that referenced
this pull request
Aug 7, 2025
nsavoire
added a commit
that referenced
this pull request
Sep 19, 2025
nsavoire
added a commit
that referenced
this pull request
Sep 22, 2025
nsavoire
added a commit
that referenced
this pull request
Nov 19, 2025
nsavoire
added a commit
that referenced
this pull request
Nov 24, 2025
nsavoire
added a commit
that referenced
this pull request
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.