Refactor ExecutableMetadata handling #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When uploading elf symbols, it is sometimes necessary to open a file other than the reported executalle (eg. to look for separate debug information).
This change makes systemProcess.Open return `/proc/<profiler_pid>/fd/<elf_fd>` as actual path instead of `/proc/<process_pid>/map_files/<mapping>`. The upside of this change is that the new path remains valid even after the target process has been terminated, while the old path becomes invalid.
* pass both go and gnu build ids
If a zero size is provided for the tracehandler cache, the cache will not be created.
* Avoid using the GITHUB_TOKEN for pr creation * fixing repo reference
Store the metadata of the backing file in the Frame itself. This allows never losing the metadata. Remove unneeded LRU caches.
This reverts commit c924504.
This allows clients to provide a reporter to the tracer for reporting executable metadata.
nsavoire
force-pushed
the
nsavoire/executable_metadata_refactoring
branch
from
9081ac9 to
42bba66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is open-telemetry#671 which is not yet merged upstream.
The goal is to benefit from new
ExecutableMetadatastruct that contains aProcessmember and thus allows opening ELF files.