Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Extended sampling support #1914

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

pierotibou
Copy link
Contributor

Motivation

Bob has implemented extended sampling and it should be released as part of 0.96.0
DataDog/dd-trace-php#2384.

Changes

Changed the manifest file.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

@pierotibou pierotibou force-pushed the pierre/php-extended-sampling-support branch from c252e56 to 87a6a7d Compare December 12, 2023 09:26
@pierotibou pierotibou marked this pull request as ready for review December 20, 2023 14:18
@pierotibou pierotibou requested review from a team as code owners December 20, 2023 14:18
@pierotibou pierotibou merged commit e368c43 into main Dec 21, 2023
319 of 320 checks passed
@pierotibou pierotibou deleted the pierre/php-extended-sampling-support branch December 21, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants