Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Base image for spring-boot #3678

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

cbeauchesne
Copy link
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

RUN mvn -Dmaven.repo.local=/maven package

# TODO: is this line download stuff? if yes, include it in base image
RUN mvn -Dmaven.repo.local=/maven package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does. Unfortunately some things are only fetched once the sources are available and all build stages run. But at least what is fetched does not depend on sources' contents except pom.xml, so it would be ok to include them in the base image for build (perhaps deleting them later?).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, we could preload them in the base image, and so this command won't have to download it, but would pick it from the base image? If yes, that's perfect.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think the main aspect to consider here is not mix old with new sources. I'm not sure what's COPY behavior if you do it over an existing directory. If it fully replaces the directory, then it's fine to include the sources as is and run package in the base image. Otherwise, it's just the same but deleting the sources from base image before finishing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's zoom when we'll be back !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants