Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodejs] Specify minimum version for Test_Config_ClientIPHeaderEnabled_False #3706

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Dec 17, 2024

Motivation

Update manifest file to reflect minimum nodejs version for #3657

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mhlidd mhlidd marked this pull request as ready for review December 17, 2024 16:42
@mhlidd mhlidd requested review from a team as code owners December 17, 2024 16:42
Copy link
Member

@simon-id simon-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i tested locally with version 3.13.0 of dd-trace, and it passes 👍

@mhlidd mhlidd merged commit 77a7d33 into main Dec 18, 2024
34 checks passed
@mhlidd mhlidd deleted the mhlidd/update_nodejs_trace_client_enabled branch December 18, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants