Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test multiple rasp during one request #3989

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

estringana
Copy link
Contributor

Motivation

During the implementation of RASP TELEMETRY on php team, it was found that the WAF will match only once if rasp data is given as persistent instead of ephemeral.

Here you can see the signature of the ddwaf_run method on the WAF: https://github.com/DataDog/libddwaf/blob/1de83d9ae46cb453240202bb5ee568c4cd0d35b4/src/interface.cpp#L190

This test aims to ensure that all languages are passing rasp data as ephemeral, otherwise on scenarios like this, the waf will only report one match instead of three.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@estringana estringana force-pushed the estringana/test-multiple-rasp-one-request branch 2 times, most recently from 093d679 to d86e0ab Compare February 5, 2025 10:25
@estringana estringana force-pushed the estringana/test-multiple-rasp-one-request branch from d86e0ab to 9f00a41 Compare February 5, 2025 10:26
@estringana estringana force-pushed the estringana/test-multiple-rasp-one-request branch from bc35180 to bf53521 Compare February 5, 2025 15:12
@estringana estringana marked this pull request as ready for review February 7, 2025 09:36
@estringana estringana requested review from a team as code owners February 7, 2025 09:36
@estringana estringana requested review from gnufede, wantsui, Mariovido, sezen-datadog and mcculls and removed request for a team February 7, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants