Test multiple rasp during one request #3989
Open
+337
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During the implementation of RASP TELEMETRY on php team, it was found that the WAF will match only once if rasp data is given as persistent instead of ephemeral.
Here you can see the signature of the
ddwaf_run
method on the WAF: https://github.com/DataDog/libddwaf/blob/1de83d9ae46cb453240202bb5ee568c4cd0d35b4/src/interface.cpp#L190This test aims to ensure that all languages are passing rasp data as
ephemeral
, otherwise on scenarios like this, the waf will only report one match instead of three.Changes
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present