Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python][mlob] config norm rule for auto span linking #4081

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

lievan
Copy link
Contributor

@lievan lievan commented Feb 12, 2025

Motivation

adds config norm rule for auto span linking

dd-go pr https://github.com/DataDog/dd-go/pull/170061

want to make this test pass: https://github.com/DataDog/system-tests/blob/main/docs/edit/runbook.md#test_config_telemetry_completeness

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@lievan lievan requested a review from a team as a code owner February 12, 2025 17:28
@lievan lievan requested review from BridgeAR and removed request for a team February 12, 2025 17:28
@lievan lievan changed the title [MLOB] config norm rule for auto span linking [python][mlob] config norm rule for auto span linking Feb 12, 2025
@lievan lievan merged commit 6aa5841 into main Feb 12, 2025
281 of 282 checks passed
@lievan lievan deleted the evan.li/span-link-norm-rule branch February 12, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants