Skip to content

Auto-activate nodejs manifest tests#6208

Open
dd-octo-sts[bot] wants to merge 4 commits intomainfrom
auto-nodejs-manifest
Open

Auto-activate nodejs manifest tests#6208
dd-octo-sts[bot] wants to merge 4 commits intomainfrom
auto-nodejs-manifest

Conversation

@dd-octo-sts
Copy link
Contributor

@dd-octo-sts dd-octo-sts bot commented Feb 4, 2026

Automated activation of easy-win tests for nodejs
View nightly workflow run

  • If you approve this PR please also merge it.
  • If the tests are failing it might be due to a change made since the last nightly system-tests run. You can close the PR, an updated one will be available tomorrow.
  • If you close the PR please also delete the branch

This commit was created from the local commit with hash 48acc8c58065e10d735dcafdcab1a453618ae0b9.
@dd-octo-sts dd-octo-sts bot requested a review from a team as a code owner February 4, 2026 13:09
@dd-octo-sts dd-octo-sts bot enabled auto-merge (squash) February 4, 2026 13:09
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 4, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 2 New flaky tests detected

tests.stats.test_stats.Test_Time_Bucketing.test_client_side_stats_bucket_alignment[fastify] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: Should have at least one stats bucket
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Time_Bucketing object at 0x7ff8cc9be930>

    def test_client_side_stats_bucket_alignment(self):
        """Test that client-side stats are aligned on 10-second intervals"""
        stats_requests = list(interfaces.library.get_data("/v0.6/stats"))
        assert len(stats_requests) > 0, "Should have at least one stats request"
...
tests.stats.test_stats.Test_Time_Bucketing.test_client_side_stats[fastify] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: Should have at least one stats bucket
assert 0 > 0
 +  where 0 = len([])

self = <tests.stats.test_stats.Test_Time_Bucketing object at 0x7ff8cc9bda60>

    def test_client_side_stats(self):
        """Test that client-side stats are properly bucketed in 10-second intervals"""
        stats_requests = list(interfaces.library.get_data("/v0.6/stats"))
        assert len(stats_requests) > 0, "Should have at least one stats request"
...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 49ce8af | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@nccatoni nccatoni marked this pull request as draft February 4, 2026 13:22
auto-merge was automatically disabled February 4, 2026 13:22

Pull request was converted to draft

@nccatoni nccatoni marked this pull request as ready for review February 5, 2026 12:37
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2f93d557a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@nccatoni nccatoni enabled auto-merge (squash) February 5, 2026 13:38
@watson watson disabled auto-merge February 5, 2026 13:48
@watson
Copy link
Contributor

watson commented Feb 5, 2026

@nccatoni I had to disable the auto-merge due to the false easy-win that would start to fail once #6129 merged

@nccatoni
Copy link
Collaborator

nccatoni commented Feb 5, 2026

Thanks @watson, I fixed the issue

Copy link
Member

@simon-id simon-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of weird changes in there, will take a look later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants