Skip to content

Fix downstream body analysis sample rate ENV name#6209

Open
Strech wants to merge 2 commits intomainfrom
appsec-60450-correct-appsec-rasp-scenario-sampling-env-name
Open

Fix downstream body analysis sample rate ENV name#6209
Strech wants to merge 2 commits intomainfrom
appsec-60450-correct-appsec-rasp-scenario-sampling-env-name

Conversation

@Strech
Copy link
Member

@Strech Strech commented Feb 4, 2026

Motivation

This is a discrepancy found between RFC API10 and system-tests

Changes

I've renamed early variant of the environment variable DD_API_SECURITY_DOWNSTREAM_REQUEST_BODY_ANALYSIS_SAMPLE_RATE into DD_API_SECURITY_DOWNSTREAM_BODY_ANALYSIS_SAMPLE_RATE

I will check which libs are failing and add a bug ticket for them

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

CODEOWNERS have been resolved as:

manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/python.yml                                                    @DataDog/apm-python @DataDog/asm-python
manifests/python_lambda.yml                                             @DataDog/system-tests-core
utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core
utils/_context/_scenarios/appsec_rasp.py                                @DataDog/system-tests-core
utils/telemetry/intake/static/config_norm_rules.json                    @DataDog/apm-sdk

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 4, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 1 New flaky test detected

tests.debugger.test_debugger_pii.Test_Debugger_PII_Redaction.test_pii_redaction_method_full[spring-boot-jetty] from system_tests_suite (Datadog) (Fix with Cursor)
KeyError: 'log170aa-acda-4453-9111-1478a6method'

self = <tests.debugger.test_debugger_pii.Test_Debugger_PII_Redaction object at 0x7fd594430f20>

    @missing_feature(
        context.library == "ruby", reason="Local variable capture not implemented for method probes", force_skip=True
    )
    @missing_feature(context.library == "nodejs", reason="Not yet implemented", force_skip=True)
    def test_pii_redaction_method_full(self):
>       self._assert()
...

🧪 8 Tests failed

    tests.test_telemetry.Test_TelemetryV2.test_config_telemetry_completeness[django-poc] from system_tests_suite (Fix with Cursor)

tests.test_telemetry.Test_TelemetryV2.test_config_telemetry_completeness[django-py3.13] from system_tests_suite (Datadog) (Fix with Cursor)
ValueError: (NOT A FLAKE) Read this quick runbook to update allowed configs: https://github.com/DataDog/system-tests/blob/main/docs/edit/runbook.md#test_config_telemetry_completeness

self = <tests.test_telemetry.Test_TelemetryV2 object at 0x7fe8581bbbf0>

    @irrelevant(
        condition=context.library not in ("python",),
        reason="This test causes to many friction. It has been replaced by alerts on slack channels",
    )
    def test_config_telemetry_completeness(self):
        """Assert that config telemetry is handled properly by telemetry intake
...
tests.test_telemetry.Test_TelemetryV2.test_config_telemetry_completeness[fastapi] from system_tests_suite (Datadog) (Fix with Cursor)
ValueError: (NOT A FLAKE) Read this quick runbook to update allowed configs: https://github.com/DataDog/system-tests/blob/main/docs/edit/runbook.md#test_config_telemetry_completeness

self = <tests.test_telemetry.Test_TelemetryV2 object at 0x7f6de8494650>

    @irrelevant(
        condition=context.library not in ("python",),
        reason="This test causes to many friction. It has been replaced by alerts on slack channels",
    )
    def test_config_telemetry_completeness(self):
        """Assert that config telemetry is handled properly by telemetry intake
...
View all
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 11229b6 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@Strech Strech force-pushed the appsec-60450-correct-appsec-rasp-scenario-sampling-env-name branch from 6ffe742 to c06999f Compare February 5, 2026 17:25
@Strech Strech force-pushed the appsec-60450-correct-appsec-rasp-scenario-sampling-env-name branch from c06999f to 8495c6b Compare February 6, 2026 12:50
@Strech Strech marked this pull request as ready for review February 6, 2026 12:53
@Strech Strech requested review from a team as code owners February 6, 2026 12:53
@Strech Strech requested review from claponcet, jandro996, taegyunkim, wconti27 and ygree and removed request for a team February 6, 2026 12:53
@Strech Strech force-pushed the appsec-60450-correct-appsec-rasp-scenario-sampling-env-name branch from 8495c6b to 11229b6 Compare February 6, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants