Skip to content

[nodejs] Enable Debugger Capture Expressesions tests for Node.js#6210

Draft
watson wants to merge 1 commit intomainfrom
watson/DEBUG-5011/capture-expressions
Draft

[nodejs] Enable Debugger Capture Expressesions tests for Node.js#6210
watson wants to merge 1 commit intomainfrom
watson/DEBUG-5011/capture-expressions

Conversation

@watson
Copy link
Contributor

@watson watson commented Feb 4, 2026

Motivation

The Node.js tracer is adding support for Capture Expressions, and we need to also enable the system-tests for it: DataDog/dd-trace-js#7431

Changes

  • Enable tests: Removed the Node.js @missing_feature decorator from the Test_Debugger_Line_Capture_Expressions test class
  • Add manifest entries: Updated manifests/nodejs.yml to activate capture expressions tests for Node.js weblogs, starting from version 5.85.0 (upcoming release)

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

Copy link
Contributor Author

watson commented Feb 4, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js
tests/debugger/test_debugger_capture_expressions.py                     @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils.py                                                 @DataDog/debugger @DataDog/system-tests-core

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 4, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 5 Tests failed

tests.debugger.test_debugger_capture_expressions.Test_Debugger_Line_Capture_Expressions.test_log_line_capture_expressions[express4] from system_tests_suite (Datadog) (Fix with Cursor)
ValueError: Snapshot for probe log3b41f-0a39-4a7a-80d4-45cf768fa763 does not contain 'captures' field

self = <tests.debugger.test_debugger_capture_expressions.Test_Debugger_Line_Capture_Expressions object at 0x7ff21badf050>

    def test_log_line_capture_expressions(self):
        self._assert()
    
        # Build expected captures with validation functions
        expected_captures = {}
        for probe_id in self.probe_ids:
...
tests.debugger.test_debugger_capture_expressions.Test_Debugger_Line_Capture_Expressions.test_log_line_capture_expressions[express4-typescript] from system_tests_suite (Datadog) (Fix with Cursor)
ValueError: Snapshot for probe logd96f2-7421-4330-9f04-b5bfa656bb1b does not contain 'captures' field

self = <tests.debugger.test_debugger_capture_expressions.Test_Debugger_Line_Capture_Expressions object at 0x7f6c2483ade0>

    def test_log_line_capture_expressions(self):
        self._assert()
    
        # Build expected captures with validation functions
        expected_captures = {}
        for probe_id in self.probe_ids:
...
tests.debugger.test_debugger_capture_expressions.Test_Debugger_Line_Capture_Expressions.test_log_line_capture_expressions[express5] from system_tests_suite (Datadog) (Fix with Cursor)
ValueError: Snapshot for probe log6fa3f-6f35-4d0b-a420-f9c9b60f7ac5 does not contain 'captures' field

self = <tests.debugger.test_debugger_capture_expressions.Test_Debugger_Line_Capture_Expressions object at 0x7f8a64c68050>

    def test_log_line_capture_expressions(self):
        self._assert()
    
        # Build expected captures with validation functions
        expected_captures = {}
        for probe_id in self.probe_ids:
...
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7a7a375 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant