Skip to content

WIP: add otel baggage php endpoints#6213

Draft
rachelyangdog wants to merge 1 commit intomainfrom
rachel.yang/php-otel-baggage-endpoints
Draft

WIP: add otel baggage php endpoints#6213
rachelyangdog wants to merge 1 commit intomainfrom
rachel.yang/php-otel-baggage-endpoints

Conversation

@rachelyangdog
Copy link
Contributor

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@rachelyangdog rachelyangdog requested review from a team as code owners February 4, 2026 22:07
@rachelyangdog rachelyangdog marked this pull request as draft February 4, 2026 22:07
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

CODEOWNERS have been resolved as:

utils/build/docker/php/common/otel_drop_in_baggage_api_otel.php         @DataDog/apm-php @DataDog/system-tests-core
manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
tests/test_baggage.py                                                   @DataDog/system-tests-core
utils/build/docker/php/apache-mod/php.conf                              @DataDog/apm-php @DataDog/system-tests-core
utils/build/docker/php/common/composer.json                             @DataDog/apm-php @DataDog/system-tests-core
utils/build/docker/php/php-fpm/php-fpm.conf                             @DataDog/apm-php @DataDog/system-tests-core

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3593b7566d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +30 to +31
RewriteRule "^/otel_drop_in_baggage_api_otel$" "/otel_drop_in_baggage_api_otel/"
RewriteRule "^/otel_drop_in_baggage_api_datadog$" "/otel_drop_in_baggage_api_datadog/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add PHP handler for /otel_drop_in_baggage_api_datadog

The rewrite enables the /otel_drop_in_baggage_api_datadog route, but a repo-wide search shows there is no corresponding PHP handler under utils/build/docker/php/common/ (only otel_drop_in_baggage_api_otel.php was added). That means the route will 404 in the PHP weblog, so Test_Baggage_Headers_Api_Datadog will fail once it’s enabled. Please add the PHP handler or keep the test skipped for PHP until it exists.

Useful? React with 👍 / 👎.

Comment on lines +1 to +3
<?php

use OpenTelemetry\API\Baggage\Baggage;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Require Composer autoload before using OTel API

otel_drop_in_baggage_api_otel.php uses OpenTelemetry\API\Baggage\Baggage but never includes vendor/autoload.php. In this repo, other PHP endpoints that use Composer deps explicitly require the autoloader (e.g., log-library.php), so this endpoint will fatally error with “Class not found” and return 500. Add the autoload include at the top of the file.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant