test(debugger): ensure span error budgets are reasonable#6224
Open
test(debugger): ensure span error budgets are reasonable#6224
Conversation
Contributor
|
|
d3870b0 to
fe883a9
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fe883a9 to
a87e67b
Compare
nccatoni
reviewed
Feb 6, 2026
Collaborator
nccatoni
left a comment
There was a problem hiding this comment.
LGTM for @DataDog/system-tests-core, you should also get a review from someone familiar with the feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add a test to verify that span decoration probes with improper expressions (e.g., "Cannot dereference field") have their error logs rate-limited to at most once per second. Currently marked as a bug for Java since span decoration probes lack probe budgets, producing 150 error snapshots for 150 requests instead of the expected ~1 per second.
Changes
test_span_probe_expression_budgetsintests/debugger/test_debugger_probe_budgets.pyto verify that error logs from span probe expression failures are rate-limited to at most 1 per second, with appropriate assertions and handling for language-specific limitations.setup_span_probe_expression_budgetsto configure and trigger the span probe expression budget scenario in the same test file.probe_span_method_budgets_expression.jsonundertests/debugger/utils/probes/to define a span probe with an intentionally failing expression, used for testing error logging and rate limiting.bugdecorator fromutilsintests/debugger/test_debugger_probe_budgets.pyto allow marking tests with known bugs, specifically for Java.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present