Conversation
This commit was created from the local commit with hash e053c1cc893f1ef54971ad417f40c28e3fd1a6cd.
dd-octo-sts
bot
requested review from
avara1986 and
sabrenner
and removed request for
a team
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b10d8f9230
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tests/appsec/iast/sink/test_insecure_cookie.py::TestInsecureCookie_ExtendedLocation: | ||
| - declaration: missing_feature | ||
| - weblog_declaration: |
There was a problem hiding this comment.
This change replaces the previous version declaration with declaration: missing_feature, which disables the test for all weblogs and versions rather than only excluding tornado. Given the surrounding entries add tornado-specific exclusions elsewhere, this looks like an unintended regression that turns off the test entirely (same pattern also appears for other ExtendedLocation entries in this block). If the intent was to keep the existing version gate and only skip tornado, use a weblog_declaration with a "*": v3.1.0.dev default plus tornado: missing_feature.
Useful? React with 👍 / 👎.
Pull request was converted to draft
Automated activation of easy-win tests for python
View nightly workflow run