-
Notifications
You must be signed in to change notification settings - Fork 415
datastore TF provider and datastore item TF provider #3388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| @@ -0,0 +1,19 @@ | |||
| resources: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't use the generator since this doesn't follow the same pattern but created a config file anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me know if i should just remove the config files since i didn't end up using them
docs/resources/datastore.md
Outdated
|
|
||
| # datadog_datastore (Resource) | ||
|
|
||
| Provides a Datadog Datastore resource. This can be used to create and manage Datadog datastore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Provides a Datadog Datastore resource. This can be used to create and manage Datadog datastore. | |
| Provides a Datadog Datastore resource. This can be used to create and manage Datadog datastores. |
OliviaShoup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! left one tiny comment :)
wfa207
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.generator/datastore-config.yaml
Outdated
| @@ -0,0 +1,19 @@ | |||
| resources: | |||
| datastore: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Non-Blocking] Should we also prefix this with datadog_ to align with the item resource below?
Or if it's easier, we can do the reverse: rename datadog_datastore_item to just datastore_item?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i actually think i'm going to delete these config files all together since i didn't use them for auto generation so they don't map correctly (especially after i made changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay that works
Summary
This PR adds Terraform support for Datadog Datastores and Datastore Items, enabling users to manage key-value data
storage through Infrastructure as Code.
New Resources
New Data Sources
Features
Example Usage
Create a datastore
resource "datadog_datastore" "users" {
name = "users-datastore"
description = "Datastore for user data"
primary_column_name = "id"
primary_key_generation_strategy = "none"
}
Add items to the datastore
resource "datadog_datastore_item" "user1" {
datastore_id = datadog_datastore.users.id
item_key = "user-123"
value = {
id = "user-123"
username = "john_doe"
email = "[email protected]"
}
}
Test Plan