[datadog_sensitive_data_scanner_standard_pattern] Fix filter matching multiple patterns due to substring collision #3402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the
filterparameter would match unintended patterns due to substring collision. For example, searching for "US Tax Identification Number Scanner" would also match "Cyprus Tax Identification Number Scanner" because "Cyprus" ends with "us".Closes #3370
Changes
dataSourceDatadogSensitiveDataScannerStandardPatternRead()to prioritize exact match over partial matchRoot Cause
The filter logic only used
strings.Contains()for matching, which caused false positives when the search term appeared as a substring in other pattern names.// Before: Only partial match
if strings.Contains(strings.ToLower(name), strings.ToLower(searchedName)) {
foundStandardPatterns = append(foundStandardPatterns, resource)
}
// After: Exact match takes priority
if name == searchedName {
exactMatch = &match
break
}
Testing