[datadog_dashboard] Add default_timeframe support

[Gurik-M]

Summary

Resolves DASHB-970 (Update the terraform resource to respect default_time)

• Adds an optional default_timeframe block to datadog_dashboard and datadog_dashboard_v2 for configuring the dashboard's default time span on load
• Supports live (type, unit, value) and fixed (type, from, to) variants, matching the dashboard API schema
• Allows default_timeframe = null on update to explicitly disable after it has been configured

Test plan

• Unit tests for build/flatten/null handling (datadog/dashboardmapping/dashboard_default_timeframe_test.go)

• Acceptance tests (cassette replay, RECORD=false):

  TF_ACC_TERRAFORM_VERSION=1.13.1 \
  RECORD=false \
  TESTARGS='-run TestAccDatadogDashboardDefaultTimeframe' \
  make testacc

  (TF_ACC_TERRAFORM_VERSION pins/downloads a Terraform CLI for the harness; optional if terraform version already works on your PATH.)

  Result (local):

  PASS datadog/tests.TestAccDatadogDashboardDefaultTimeframe (5.65s)
  PASS datadog/tests.TestAccDatadogDashboardDefaultTimeframe_import (6.23s)
  PASS datadog/tests (cached)
  

• make docs && make check-docs after merge prep

Made with Cursor

[datadog-official]

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 9 Pipeline jobs failed

Run Tests | all-checks     

Run Tests | test (1.1.5, 0, ubuntu-latest)     

See error

3 test failures: datadog_dashboard.default_timeframe_dashboard attribute 'default_timeframe.0.value' expected '1', got '0'.

Run Tests | test (1.1.5, 2, ubuntu-latest)     

See error

TestAccDatadogDashboardDefaultTimeframe_import failed due to non-refresh plan not being empty after applying the test step in resource_datadog_dashboard_default_timeframe_test.go:92.

View all 9 failed jobs.

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ad00621 | Docs | Datadog PR Page | Give us feedback!}

[yacomink]

Can you please load this claude skill: https://github.com/DataDog/claude-marketplace/tree/main/dashboard-terraform-openapi-sync and go over this change with it?

The claude skill has some conventions and pointers for making changes to the datadog_dashboard_v2 spec. One of those is preferring expanding the engine over adding custom build/flatten code for individual fields. With that guidance in place the skill gave me this suggestion:

The custom build code is all a consequence of one missing engine capability: no way to emit JSON null for a field that was cleared in HCL.

The engine already has two states for an OmitEmpty: true TypeBlock — include it or skip it. A third state (nil in the data map → serialize as JSON null) would cover this case generically. The abstraction would be a NullOnClear: bool flag on FieldSpec:

// In BuildEngineJSONFromMap, TypeBlock case:
rawVal := data[f.HCLKey]
if rawVal == nil && f.NullOnClear {
    result[f.effectiveJSONKey()] = nil  // explicit JSON null
    continue
}
// ... existing block handling unchanged ...

I'd also suggest making your OpenAPI change PR at the same time. The skill works best if you make the two changes in one session.