[datadog_custom_allocation_rule] Fix "inconsistent result after apply" on in-place update#3845
Open
billykern wants to merge 1 commit into
Open
Conversation
…update Remove UseStateForUnknown() from the computed updated, version, and last_modified_user_uuid attributes. The API changes these on every update, so pinning them to prior state failed Terraform's post-apply consistency check. Adds an in-place-update acceptance test that the existing update test missed (it changes rule_name, forcing replacement).
|
Member
|
We have an issue with integration tests coming from forks right now, so it's ok to ignore that failure. |
ashleyyip
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3829
updated,version, andlast_modified_user_uuidare computed attributes the API rewrites on every update, but they usedUseStateForUnknown(), which pins the planned value to prior state. On an in-place update the post-apply value differs from the pinned plan value, so Terraform fails the consistency check even though the update succeeded server-side.createdkeeps the modifier since it never changes after creation.The existing
...Updateacceptance test missed this because it also changesrule_name(aRequiresReplacefield), which destroys and recreates the rule rather than updating it in place. Added...InPlaceUpdate, which changes onlycosts_to_allocate, exercising the PATCH path that triggers the bug.