Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the S3 configuration error in Resource #2670

Merged
merged 2 commits into from
Dec 17, 2023

Conversation

gaoyan1998
Copy link
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Comment on lines 222 to 223
sys.resource.settings.oss.endpoint=URL of the object storage service(Endpoint)
sys.resource.settings.oss.endpoint.note=For example: https://oss-cn-hangzhou.aliyuncs.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use English parentheses

Copy link
Contributor

@zackyoungh zackyoungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zackyoungh zackyoungh merged commit 6366ecd into DataLinkDC:dev Dec 17, 2023
12 checks passed
@gaoyan1998 gaoyan1998 deleted the fix-resource branch December 18, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants