Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix added flinksqlenv after show bug #2726

Merged
merged 6 commits into from
Dec 23, 2023

Conversation

Zzm0809
Copy link
Contributor

@Zzm0809 Zzm0809 commented Dec 23, 2023

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@Zzm0809 Zzm0809 self-assigned this Dec 23, 2023
@Zzm0809 Zzm0809 requested a review from gaoyan1998 December 23, 2023 08:48
@Zzm0809 Zzm0809 added the Bug Something isn't working label Dec 23, 2023
@Zzm0809 Zzm0809 added this to the 1.0.0 milestone Dec 23, 2023
Copy link
Contributor

@gaoyan1998 gaoyan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaoyan1998 gaoyan1998 merged commit acec1e2 into DataLinkDC:dev Dec 23, 2023
12 checks passed
@Zzm0809 Zzm0809 deleted the fix-addedflinksqlenv-after-showbug branch December 28, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants