Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Optimization-4134][Web] Optimization home page icon and job detail lineage under dark theme #4137

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[Optimization-4134][Web] Optimization home page icon and job detail lineage under dark theme #4137

merged 1 commit into from
Jan 10, 2025

Conversation

MactavishCui
Copy link
Contributor

Purpose of the pull request

#4134

Brief change log

Verify this pull request

  1. Job detail lineage
    Before:
    cee6b1af5e9e2f744e086a024c86f14
    After:
    f63b52ef6678bad7dce614821b5d8d2

  2. Home Icon
    Before:
    image
    After:
    image

Zzm0809
Zzm0809 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@Zzm0809 Zzm0809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zzm0809 Zzm0809 merged commit c968389 into DataLinkDC:dev Jan 10, 2025
24 checks passed
@MactavishCui MactavishCui deleted the dev-darkThemeOpt branch January 10, 2025 02:25
@Zzm0809 Zzm0809 added the Optimization Optimization function label Jan 10, 2025
@Zzm0809 Zzm0809 added this to the 1.3.0 milestone Jan 10, 2025
@Zzm0809 Zzm0809 linked an issue Jan 10, 2025 that may be closed by this pull request
[Optimization][Web] Optimization home page icon and job detail lineage under dark theme #4134
Closed
3 tasks
@aiwenmo aiwenmo mentioned this pull request Jan 23, 2025
Open
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zzm0809 Zzm0809 Zzm0809 approved these changes

@aiwenmo aiwenmo Awaiting requested review from aiwenmo

@gaoyan1998 gaoyan1998 Awaiting requested review from gaoyan1998

@zackyoungh zackyoungh Awaiting requested review from zackyoungh

Assignees

@MactavishCui MactavishCui

Labels
Optimization Optimization function
Projects
Dinky Roadmap
Status: Done
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

[Optimization][Web] Optimization home page icon and job detail lineage under dark theme
2 participants
@MactavishCui @Zzm0809